| Summary: | missing icon in System Settings | ||
|---|---|---|---|
| Product: | Network Management | Reporter: | Christopher Yeleighton <giecrilj> |
| Component: | Control Module | Assignee: | Lamarque V. Souza <lamarque> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | carlsymons |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 4.8.1 | |
| Attachments: |
Network Manager Help menu with About command disabled
Network Settings missing Network Manager icon |
||
|
Description
Christopher Yeleighton
2012-02-09 12:50:13 UTC
Can you send me a screenshot of the problems? I do not see any missing icon here and how do you "tell Network Manager module to tell about itself"? Created attachment 68651 [details]
Network Manager Help menu with About command disabled
Created attachment 68652 [details]
Network Settings missing Network Manager icon
(In reply to comment #3) > Created an attachment (id=68652) [details] > Network Settings missing Network Manager icon The icon used for the other modules is named preferences-system-network Git commit 786d367e9d18a067f1ec1b474b0f843bd8bec697 by Lamarque V. Souza. Committed on 09/02/2012 at 18:14. Pushed by lvsouza into branch 'master'. Add about data for kcm modules. You can see it in systemsettings by selecting "Network Settings" -> "Network Connection" -> clicking on the button with a '?' and then on "About Manage Connections" menu. M +10 -0 settings/config/manageconnectionwidget.cpp M +11 -0 settings/config/managetraywidget.cpp http://commits.kde.org/networkmanagement/786d367e9d18a067f1ec1b474b0f843bd8bec697 Git commit eb1cd4a9190fa3b0262d65d350fb6e1d9828e9e4 by Lamarque V. Souza. Committed on 09/02/2012 at 18:14. Pushed by lvsouza into branch 'nm09'. Add about data for kcm modules. You can see it in systemsettings by selecting "Network Settings" -> "Network Connection" -> clicking on the button with a '?' and then on "About Manage Connections" menu. M +10 -0 settings/config/manageconnectionwidget.cpp M +10 -0 settings/config/managetraywidget.cpp http://commits.kde.org/networkmanagement/eb1cd4a9190fa3b0262d65d350fb6e1d9828e9e4 We install the networkmanager.png file mentioned in kcm_networkmanager.desktop. It the package does not include it then it is downstream bug and you should contact your distribution mantainers to fix it. Git commit 5a2669f151e65dca5adededade2b30cc40dc7c0f by Lamarque V. Souza. Committed on 13/02/2012 at 13:14. Pushed by lvsouza into branch 'KDE/4.8'. Always install networkmanager.png icons regardless which backend is going to be compiled (networkmanager-0.7 or networkmanager_fake-0.9). networkmanager_fake-0.9 does not install any icon, then when using Plasma NM from branch nm09 there is no icon for it. Plasma NM's master branch currently installs the icons, I will remove them from master branch to prevent conflicts with this commit. (cherry picked from commit e5a73150a2bf9a0b0e4c3520c89ec981a097f333) M +1 -0 solid/CMakeLists.txt R +- -- solid/icons/ox22-app-networkmanager.png [from: solid/networkmanager-0.7/ox22-app-networkmanager.png - 100% similarity] R +- -- solid/icons/ox32-app-networkmanager.png [from: solid/networkmanager-0.7/ox32-app-networkmanager.png - 100% similarity] R +- -- solid/icons/ox64-app-networkmanager.png [from: solid/networkmanager-0.7/ox64-app-networkmanager.png - 100% similarity] M +0 -2 solid/networkmanager-0.7/CMakeLists.txt M +0 -2 solid/networkmanager_fake-0.9/CMakeLists.txt http://commits.kde.org/kde-workspace/5a2669f151e65dca5adededade2b30cc40dc7c0f Git commit e5a73150a2bf9a0b0e4c3520c89ec981a097f333 by Lamarque V. Souza. Committed on 13/02/2012 at 13:14. Pushed by lvsouza into branch 'master'. Always install networkmanager.png icons regardless which backend is going to be compiled (networkmanager-0.7 or networkmanager_fake-0.9). networkmanager_fake-0.9 does not install any icon, then when using Plasma NM from branch nm09 there is no icon for it. Plasma NM's master branch currently installs the icons, I will remove them from master branch to prevent conflicts with this commit. M +1 -0 solid/CMakeLists.txt R +- -- solid/icons/ox22-app-networkmanager.png [from: solid/networkmanager-0.7/ox22-app-networkmanager.png - 100% similarity] R +- -- solid/icons/ox32-app-networkmanager.png [from: solid/networkmanager-0.7/ox32-app-networkmanager.png - 100% similarity] R +- -- solid/icons/ox64-app-networkmanager.png [from: solid/networkmanager-0.7/ox64-app-networkmanager.png - 100% similarity] M +0 -2 solid/networkmanager-0.7/CMakeLists.txt M +0 -2 solid/networkmanager_fake-0.9/CMakeLists.txt http://commits.kde.org/kde-workspace/e5a73150a2bf9a0b0e4c3520c89ec981a097f333 *** Bug 289069 has been marked as a duplicate of this bug. *** |