| Summary: | Plasmoid does not monitor TextChannel:pendingMessagesRemoved() | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] telepathy | Reporter: | David Edmundson <kde> |
| Component: | chat-plasmoid | Assignee: | Telepathy Bugs <kde-telepathy-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | 0.4.0 | ||
| Platform: | Unlisted Binaries | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
|
Description
David Edmundson
2012-02-07 13:11:31 UTC
Git commit 1df722aa5c796647e87dfbc9690d63e1bf5c53f2 by Lasath Fernando. Committed on 13/02/2012 at 02:32. Pushed by fernando into branch 'master'. The Delegate Channels Patch a.k.a David's massive patch In the plasmoid: Convert plasmoid to a handler from an observer Support delegate channels (via a nasty hack currently) Add popout button to delegate to main text UI Merge the conversationsModel and handler into one class Fix exposing a load of items to QML for no reason. Some additional tidying. (and some additional messying :-) ) Clear unread messages on TextChannel::pendingMessagesRemoved() In the textUI: Always raise the window in the main Text UI handleChannel unless hint explicitly says otherwise. Additionally fixes a bug in which reconnecting an account could cause the tabs to 'randomly' switch. REVIEW: 103908 M +10 -3 app/chat-tab.cpp M +8 -10 app/telepathy-chat-ui.cpp M +13 -1 plasmoid/declarative-plugin/conversation.cpp M +6 -3 plasmoid/declarative-plugin/conversation.h M +74 -22 plasmoid/declarative-plugin/conversations-model.cpp M +13 -3 plasmoid/declarative-plugin/conversations-model.h M +0 -10 plasmoid/declarative-plugin/messages-model.cpp M +0 -3 plasmoid/declarative-plugin/messages-model.h M +0 -9 plasmoid/declarative-plugin/qml-plugins.cpp M +14 -51 plasmoid/declarative-plugin/telepathy-text-observer.cpp M +9 -7 plasmoid/declarative-plugin/telepathy-text-observer.h M +20 -3 plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml M +7 -9 plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml http://commits.kde.org/telepathy-text-ui/1df722aa5c796647e87dfbc9690d63e1bf5c53f2 |