Summary: | Warnings when building oxygen-gtk3 against gtk-3.3.6 | ||
---|---|---|---|
Product: | [Plasma] Oxygen | Reporter: | nucleo <nucleo> |
Component: | gtk2-engine | Assignee: | Hugo Pereira Da Costa <hugo.pereira.da.costa> |
Status: | CLOSED FIXED | ||
Severity: | minor | CC: | b7.10110111, hugo.pereira.da.costa, web |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Unlisted Binaries | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
nucleo
2012-01-08 23:16:51 UTC
Hmm, I think we'll just use -Wno-deprecated-declarations as workaround for the first release and only make real fix in bug-fix release, since some of these new functions seem to not be drop-in replacements for deprecated ones, so they'll require some testing. @Hugo, do you agree? So far, we've only compiled and tested the code against gtk3.0 Also, the warnings are only in ,the demo code (which is largely imported from 2.0) So. My concern about the fixing of all deprecated warnings is that the code would not compile with older gtk3 versions. Which is then a pain to deal with on kde-look. So since only the helper app (oxygen-gtk-demo) is concerned, I'd rather put in the no-deprecated there and only fix when things actually crash (possibly adding checks on gtk version). Makes sense ? Will push as soon as I have a running gtk3.3 here. PS: thanks for reporting !! No "deprecate" warning with gtk+3.2.6 (which is the stable branch) ... sorry 3.2.3 mmmm (sorry for the many posts). After compiling against 3.3.6, there also are deprecated stuff in the core code. But again, we'll have to leave with it, since they only appear in 3.3 (and not in 3.2, against which the code is likely not to compile any more if we fix the above). So. Either add no-deprecated, or live with the warnings ... ok. Last one. At least some of the deprecated signals have equivalent since 3.0 (e.g. gtk_box_new). So I'll give it a shot in the end. Re-oppening and will keep you posted. Git commit 2ffe571f2258513de18c5f7ee5c91092fb3c348b by Hugo Pereira Da Costa. Committed on 09/01/2012 at 16:10. Pushed by hpereiradacosta into branch 'gtk3'. removed deprecated use of gtk_vbox/gtk_hbox. changed GtkTable into GtkGrid change HScale and VScale into Scale. M +28 -28 demo/oxygenbuttondemowidget.cpp M +3 -3 demo/oxygendemodialog.cpp M +2 -2 demo/oxygendemowidget.cpp M +5 -5 demo/oxygenframedemowidget.cpp M +15 -15 demo/oxygeninputdemowidget.cpp M +1 -1 demo/oxygenlistdemowidget.cpp M +5 -5 demo/oxygensliderdemowidget.cpp M +6 -6 demo/oxygentabdemowidget.cpp http://commits.kde.org/oxygen-gtk/2ffe571f2258513de18c5f7ee5c91092fb3c348b Git commit a52aab3a18d071a39a6518326ef3d1ee33bda555 by Hugo Pereira Da Costa. Committed on 09/01/2012 at 16:29. Pushed by hpereiradacosta into branch 'gtk3'. changed gtk_h/vscrollbar_new into gtk_scrollbar_new M +2 -2 demo/oxygensliderdemowidget.cpp http://commits.kde.org/oxygen-gtk/a52aab3a18d071a39a6518326ef3d1ee33bda555 Git commit b7a33039984c53502978c9e006f551f942bd1ccb by Hugo Pereira Da Costa. Committed on 09/01/2012 at 16:36. Pushed by hpereiradacosta into branch 'gtk3'. changed hseparator into separator M +1 -1 demo/oxygeninputdemowidget.cpp http://commits.kde.org/oxygen-gtk/b7a33039984c53502978c9e006f551f942bd1ccb Git commit 577e253f20e614decd353fc2010909e79747cb5c by Hugo Pereira Da Costa. Committed on 09/01/2012 at 16:52. Pushed by hpereiradacosta into branch 'gtk3'. use gtk_style_context_reset_widgets instead of gtk_rc_reset_styles comment out call to deprecated gtk_style_attach M +2 -2 src/oxygendbus.cpp http://commits.kde.org/oxygen-gtk/577e253f20e614decd353fc2010909e79747cb5c Git commit a7b3372618d9d29fc407bd5bb113e6484a858c6a by Hugo Pereira Da Costa. Committed on 09/01/2012 at 17:04. Pushed by hpereiradacosta into branch 'gtk3'. use gdk_device_ungrab instead of gdk_pointer_ungrab M +9 -1 src/oxygenwindowmanager.cpp http://commits.kde.org/oxygen-gtk/a7b3372618d9d29fc407bd5bb113e6484a858c6a Git commit 04ab50a593374d86b985a198d375186ca49d52b8 by Hugo Pereira Da Costa. Committed on 09/01/2012 at 17:24. Pushed by hpereiradacosta into branch 'gtk3'. use gdk_window_get_device_position instead of deprecated gdk_window_get_pointer. M +6 -2 src/animations/oxygenhoverdata.cpp M +5 -2 src/animations/oxygenmenubarstatedata.cpp M +6 -3 src/animations/oxygenmenustatedata.cpp M +5 -2 src/animations/oxygenscrolledwindowdata.cpp M +9 -3 src/animations/oxygentabwidgetdata.cpp M +5 -2 src/animations/oxygentreeviewdata.cpp http://commits.kde.org/oxygen-gtk/04ab50a593374d86b985a198d375186ca49d52b8 ok. That should fix "most" of the warnings. I actually had to revert to gtk-3.0 because updating to 3.3 badly screwed my system (breaking my mageia perl-gtk apps because of the associated update to glib), so that all the above has been tested to 3.0 I could not check whether there remained warnings (cause the above methods are not deprecated in 3.0 yet). However, I did check that things are still working allright. Nucleo, please double check, and report about remaining warnings. (note: the one about "registered", is a false positive. It is used in #if OXYGEN_DEBUG, so I want to keep the code there, despite the warning.) Thanks in advance, Hugo Builds against gtk-3.0.12 and 3.2.2 are fine. But against 3.3.6 still have two warnings: /builddir/build/BUILD/oxygen-gtk3-1.2.0/src/oxygengtkutils.cpp:71:13: warning: 'void gtk_widget_get_pointer(GtkWidget*, gint*, gint*)' is deprecated (declared at /usr/include/gtk-3.0/gtk/gtkwidget.h:754): Use 'gdk_window_get_device_position' instead [-Wdeprecated-declarations] /builddir/build/BUILD/oxygen-gtk3-1.2.0/src/oxygengtkutils.cpp:71:48: warning: 'void gtk_widget_get_pointer(GtkWidget*, gint*, gint*)' is deprecated (declared at /usr/include/gtk-3.0/gtk/gtkwidget.h:754): Use 'gdk_window_get_device_position' instead [-Wdeprecated-declarations] Git commit 0e268f377af323579fe16ecadf0efab5ffc54cea by Hugo Pereira Da Costa. Committed on 09/01/2012 at 21:27. Pushed by hpereiradacosta into branch 'gtk3'. use gtk_widget_get_display instead of gdk_display_get_default. use gdk_window_get_device_position instead of gtk_widget_get_pointer M +1 -1 src/animations/oxygenhoverdata.cpp M +1 -1 src/animations/oxygenmenubarstatedata.cpp M +1 -1 src/animations/oxygenmenustatedata.cpp M +1 -1 src/animations/oxygenscrolledwindowdata.cpp M +1 -1 src/animations/oxygentabwidgetdata.cpp M +1 -1 src/animations/oxygentreeviewdata.cpp M +7 -2 src/oxygengtkutils.cpp http://commits.kde.org/oxygen-gtk/0e268f377af323579fe16ecadf0efab5ffc54cea ok. Last warning fixed. Also cleanup retrieval of gdk_display. Closing. Thanks nucleo ! Feel free to reopen if there are further warnings, or if you notice any regression. Hugo Now all builds are fine. Will try to test it. Thanks. |