Bug 289299

Summary:	Kate Search & Replace no feedback in Read Only mode
Product:	[Applications] kate	Reporter:	Unknown <null>
Component:	search	Assignee:	Kåre Särs <kare.sars>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kare.sars, kwrite-bugs-null, shentey
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:	http://commits.kde.org/kate/34e29765afd8fa6ee3a4566a5e88a599279035e0	Version Fixed In:

Description Unknown 2011-12-18 18:50:42 UTC

Version:           unspecified (using Devel) 
OS:                Linux

If a file is in read-only mode and you search&replace a word that is present in the file, kate feedbacks as if the words were successfully replaced. 

Reproducible: Always

Steps to Reproduce:
Go in read only mode in a file, search&replace for a word present in the file, 


Expected Results:  
Kate should instead warn somewhere that the file is in read-only mode and that it cannot replace strings.

Comment 1 Kåre Särs 2011-12-19 10:22:58 UTC

Thanks for the report.

The change is not written to file until the user explicitly saves the document and at moment (s)he will be notified, but it would be nice to get a warning before that.... Unfortunately I don't think we can add it to KDE 4.8 as that would add a new translated string. But it is definitely on my TODO for 4.9

Comment 2 Christoph Cullmann 2012-11-02 20:22:57 UTC

Git commit 34e29765afd8fa6ee3a4566a5e88a599279035e0 by Christoph Cullmann.
Committed on 02/11/2012 at 21:22.
Pushed by cullmann into branch 'master'.

disable replace/replace all if document is read-only, like we anyway replace the replace action in the menu

M  +10   -0    part/search/katesearchbar.cpp
M  +3    -0    part/search/katesearchbar.h
M  +4    -0    part/view/kateview.cpp

http://commits.kde.org/kate/34e29765afd8fa6ee3a4566a5e88a599279035e0