Summary: | complex layer name saved in *.ora, not read at opening | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | David REVOY <info> |
Component: | General | Assignee: | Halla Rempt <halla> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | halla |
Priority: | NOR | ||
Version: | git master (please specify the git hash!) | ||
Target Milestone: | --- | ||
Platform: | Unlisted Binaries | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | a ora file funny test : Sad buny if fail / Happy bunny when fixed |
Description
David REVOY
2011-12-18 00:00:53 UTC
Could you attach the file? Created attachment 66844 [details]
a ora file funny test : Sad buny if fail / Happy bunny when fixed
Sure, I attached another file , but this file reproduce the mistake ( because I can't post Mango concept art for the moment ). I played to make a little game with it :) I see the problem. Actually the problem is that the name starts with a diget. In that case Krita goes into a special mode to load an embedded document or so. For developers: The problem is in KoStore line 594. Not sure what specification that is following. Outch! That looks like it's some sort of hack for old-style KOffice documents... I'd mark this bug as a calligra-common bug, but that would probably mean that I'd lose track of it. Git commit 8ff282b90d8f66c17f393bfa2ba89eeedc896c7d by Boudewijn Rempt. Committed on 18/12/2011 at 14:06. Pushed by rempt into branch 'master'. Show the happy bunny! Krita's use of KoStore is pretty old-fashioned, and we don't need the name expansion used by the unfinished, 10-year old filter-in-filter feature that presumably is the reason for doing weird things to paths in a store of they start with a digit. KoStore needs a thorough clean-up, but for now, setting disallowNameExpansion is enough. BUG:289242 M +1 -0 krita/plugins/formats/odg/kis_odg_import.cc M +2 -1 krita/plugins/formats/ora/ora_converter.cc M +2 -0 krita/ui/kis_clipboard.cc M +1 -1 krita/ui/kis_mimedata.cpp http://commits.kde.org/calligra/8ff282b90d8f66c17f393bfa2ba89eeedc896c7d |