Bug 288960

Summary: Add "Present Windows - Window Class" to "Screen Edges" functions
Product: [Plasma] kwin Reporter: Michael Bach <phaebz>
Component: effects-window-managementAssignee: KWin default assignee <kwin-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist    
Priority: NOR    
Version: 4.7.4   
Target Milestone: 4.9   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: patch

Description Michael Bach 2011-12-14 11:18:59 UTC 
Version:           4.7.4 (using KDE 4.7.3) 
OS:                Linux

Running on KDE 4.7.4 (was not available in the dropdown list, btw)

when configuring screen edge actions in System Settings > Workspace Behavior > Screen Edges, I am able to assign "Present Windows - All Desktops" and "Present Windows - Current Desktop" to screen edges.

Why is there no option to assign "Present Windows - Window Class"? It would be very useful IMHO and it is already available together with the other "Present Windows" functions under System Settings > Shortcuts and Gestures > Global Shortcuts > KWin

Thanks for reading

Reproducible: Always



Expected Results:  
"Present Windows - Window Class" should be available in "Screen Edges" functions
Comment 1 Thomas Lübking 2011-12-14 16:22:36 UTC 
Patch is simple - but requires a new visible string, what means it very likely NOT be applied before 4.9 :-(
Comment 2 Michael Bach 2011-12-18 19:41:48 UTC 
I am using packages from the repos. I compile some packages on my own, but nothing as complex as kde. I am somewhat surprised that this seeminlgy simple addition can not be added easily.
Comment 3 Thomas Lübking 2011-12-18 20:02:13 UTC 
i wrote the patch in 5 minutes.
the problem is, that it would enforce an update of the translation files and we're in i18n feeze for 4.8 since quite some time.

once i gained world domination, i'll forbid all languages but one (you hopefully like mandarin ;-) but for now, we got to stick with all the release cycle implications. sory
Comment 4 Thomas Lübking 2011-12-18 21:31:33 UTC 
Created attachment 66887 [details]
patch

patch, applies on 4.8
Comment 5 Michael Bach 2011-12-18 22:08:21 UTC 
I thought as much. Freeeze. Hm.

Please do not gain world domination - although, in fact, I like Mandarin! :-)

I'll gladly stick with the release cycle implications - it was just bad timing
on my side.

Thanks for supplying the patch. Maybe one day I feel brave enough...
Comment 6 Martin Flöser 2012-03-13 20:18:53 UTC 
that patch should be committed, shouldn't it?
Comment 7 Thomas Lübking 2012-03-13 20:25:51 UTC 
nope, rots on my HDD - i'll take this as ship it and push it to master and close this wish by the commit.
Comment 8 Michael Bach 2012-03-13 21:19:17 UTC 
Wish can be closed. I will check out the new feature in 4.9. Thanks for providing and committing!
Comment 9 Thomas Lübking 2012-03-14 01:41:54 UTC 
Git commit d458981b61a0e636f21d509980960acaf71e022e by Thomas Lübking.
Committed on 24/12/2011 at 20:26.
Pushed by luebking into branch 'master'.

add present windows by class to active screen edges

M  +22   -3    kwin/effects/presentwindows/presentwindows.cpp
M  +1    -0    kwin/effects/presentwindows/presentwindows.h
M  +10   -0    kwin/kcmkwin/kwinscreenedges/main.cpp
M  +1    -0    kwin/kcmkwin/kwinscreenedges/main.h

http://commits.kde.org/kde-workspace/d458981b61a0e636f21d509980960acaf71e022e