Summary: | Preview settings don't change until dolphin restarts | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | Todd <toddrme2178> |
Component: | general | Assignee: | Peter Penz <peter.penz19> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | frank78ac |
Priority: | NOR | Keywords: | investigated, reproducible |
Version: | 1.99 | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 4.8.0 | |
Attachments: | sets the m_enabledplugins in kFileItemModelRolesUpdater |
Description
Todd
2011-12-11 14:47:51 UTC
Thanks, I can confirm this regression in master. Note that the new preview settings are applied immediately to new tabs and new split views. The reason is that KFileItemModelRolesUpdater sets its "m_enabledPlugins" member in its constructor, but it is currently not updated when the user changes the preview settings. Created attachment 66831 [details]
sets the m_enabledplugins in kFileItemModelRolesUpdater
It updates the m_enabledplugins but already shown previews won't change.
Git commit 8152ff4f6bbfe13eea8a56ade04e4697cab4c68d by Peter Penz. Committed on 21/12/2011 at 21:45. Pushed by ppenz into branch 'KDE/4.8'. Update previews when the preview-plugin settings have changed Thanks to Janardhan Reddy for the initial patch. BUG: 288726 FIXED-IN: 4.8.0 M +13 -4 dolphin/src/kitemviews/kfileitemlistview.cpp M +17 -0 dolphin/src/kitemviews/kfileitemlistview.h M +11 -0 dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp M +1 -4 dolphin/src/kitemviews/kfileitemmodelrolesupdater.h M +7 -0 dolphin/src/views/dolphinitemlistcontainer.cpp http://commits.kde.org/kde-baseapps/8152ff4f6bbfe13eea8a56ade04e4697cab4c68d Git commit 9f3cba487976536c619e4f0e275107f6ee910153 by Peter Penz. Committed on 21/12/2011 at 21:45. Pushed by ppenz into branch 'master'. Update previews when the preview-plugin settings have changed Thanks to Janardhan Reddy for the initial patch. BUG: 288726 FIXED-IN: 4.8.0 M +13 -4 dolphin/src/kitemviews/kfileitemlistview.cpp M +17 -0 dolphin/src/kitemviews/kfileitemlistview.h M +11 -0 dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp M +1 -4 dolphin/src/kitemviews/kfileitemmodelrolesupdater.h M +7 -0 dolphin/src/views/dolphinitemlistcontainer.cpp http://commits.kde.org/kde-baseapps/9f3cba487976536c619e4f0e275107f6ee910153 |