Summary: | Enhance backlight detection in powerdevil/backend/upower/backlighthelper.cpp | ||
---|---|---|---|
Product: | [Frameworks and Libraries] solid | Reporter: | Corentin Chary <corentin.chary> |
Component: | powermanagement | Assignee: | Alex Fiestas <afiestas> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | afiestas, bmangentoo, darkbasic, fedotov.i.f, lukas, rdieter |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Unlisted Binaries | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 4.9 |
Description
Corentin Chary
2011-12-04 09:09:50 UTC
Lukas, Alex, can you please look into this? Added to my TODO list, will take a look ASAP. Would be nice, thx Alex, assigning :) Any updates on this? I have the same issue on an HP laptop with intel_backlight. I am not an active programmer but am dangerous enough to try and help out in any way possible. If there is something I can assist with I would be more than happy to. Just discussed this with Richard Hughsie and the way to go seems to be: 1-Use XRandR if possible 2-firmware->platform->raw Going to work on it right now, though I'm a little bit afraid of putting this in 4.8.1 without testing. Maybe 4.8.2 I will be happy to test Alex whenever you like. Alex, I think this bug I filed is some what related to this bug as well. https://bugs.kde.org/show_bug.cgi?id=292873 Git commit 018679ecdd07a2fd8dfb27df79355465252e8bc2 by Alex Fiestas. Committed on 02/02/2012 at 23:59. Pushed by afiestas into branch 'KDE/4.8'. Put acpi_video1/0 before intel_backlight Now we know that firmware interface should be put BEFORE the raw ones so in this case, acpi_video1/0 are firmware and intel_backlight is RAW. Related: bug 292873 M +4 -3 powerdevil/daemon/backends/upower/backlighthelper.cpp http://commits.kde.org/kde-workspace/018679ecdd07a2fd8dfb27df79355465252e8bc2 Git commit 5257ff19aa3e779a9e07cc49ee82cca7a051b558 by Alex Fiestas. Committed on 03/02/2012 at 02:12. Pushed by afiestas into branch 'master'. If kernel newer than 2.6.36 use the backlight type instead of whitelist If the kernel is newer than 2.6.36 it indicates the type of the backlight wether it is a firmware/platform or raw. We should attempt to connect to these interfaces in this order. This should fix any compatibility issue we have right now and make this code comaptible with drivers that may appear in the future. Related: bug 292873 CCMAIL: lukas@kde.org FIXED-IN: 4.9 M +97 -5 powerdevil/daemon/backends/upower/backlighthelper.cpp M +19 -0 powerdevil/daemon/backends/upower/backlighthelper.h http://commits.kde.org/kde-workspace/5257ff19aa3e779a9e07cc49ee82cca7a051b558 Will backport to KDE 4.8.1 or 4.8.2 if it is demonstrate stable enough. On Friday 03 February 2012 01:31:35 Alex Fiestas wrote:
> https://bugs.kde.org/show_bug.cgi?id=288180
>
>
>
>
>
> --- Comment #10 from Alex Fiestas <afiestas kde org> 2012-02-03 01:31:34
> --- Will backport to KDE 4.8.1 or 4.8.2 if it is demonstrate stable enough.
Alex,
I am on Gentoo and learning a lot but am curious how I could implement your
fix to test? We have access to developer sources but I would rather not run
that on my laptop. Is there any way to implement this outside of running
unstable sources? I have the source for kde-workspace-4.8.0 so I suppose I
could just patch that?
If you have time any advice would be great.
Alex, two comments on your patch: - I'd check if the backlight have a "type" file directly instead of checking the kernel version (a kernel patch can be backported). - Could you add a setting to "force" to use a specific backlight ? In some cases acpi_video is available but non-functional for example. Aaron: the patch probably cleanly apply on 4.7 two (or is easy to adapt to). So patching your ebuild to apply thoses two patches should be enought to test without breaking your system with a make / make install. Ping. Would it be possible for force the backlight (or to override the whitelist) with a user-defined setting ? Another user asked that to me again today. Thanks, Yes it would be nice... Thanks, Niccolò I was able to resolve my issue with the following grub settings: kernel /boot/bzImage root=/dev/sda3 acpi_osi=Linux acpi_backlight=vendor Thanks, it did work for me. |