| Summary: | KMahjongg after shuffle no information about "no moves left" | ||
|---|---|---|---|
| Product: | [Applications] kmahjongg | Reporter: | Christian Krippendorf <CerebrosuS> |
| Component: | general | Assignee: | Mauricio Piacentini <piacentini> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | CerebrosuS, kde-games-bugs |
| Priority: | NOR | ||
| Version: | 0.8 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: | Solves the bug. | ||
SVN commit 1268724 by krippendorf: BUG: 287411 FIXED-IN: KDE SC 4.8 REVIEW: 6837 After shuffle the stones because no moves left, you will now get a dialog about "No moves left" if the game isn't solvable. M +16 -2 boardwidget.cpp M +5 -0 boardwidget.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1268724 |
Created attachment 66005 [details] Solves the bug. Version: 0.8 (using KDE 4.7.3) OS: Linux After running in a non solveable combination i get informated by KMahjongg, that no moves left. After shuffle and the game is not solveable too, i don't get any information about not solveable game. Reproducible: Always Steps to Reproduce: Uncheck creation of solveable games. Play a game until it is unsolveable and then shuffle until an unsolveable game will be created. Actual Results: I won't get any information after shuffle and not solveable, that no moves left. Expected Results: A information dialog about no moves left. I add a patch which solved this bug (i feel like this is a bug). Simple extract the moving left tests and the dialog output in a separate method. This method gets called from the shuffle and the mouseEvent methods.