Bug 283646

Summary:	Remove “You cannot drop a folder on itself“
Product:	[Applications] dolphin	Reporter:	Kai Uwe Broulik <kde>
Component:	view-engine: details mode	Assignee:	Peter Penz <peter.penz19>
Status:	RESOLVED FIXED
Severity:	normal	CC:	frank78ac
Priority:	NOR	Keywords:	reproducible
Version:	1.99
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:	4.8.0

Description Kai Uwe Broulik 2011-10-09 12:53:10 UTC

Version:           1.99 (using Devel) 
OS:                Linux

The most useless message of all times has now become a modal dialog interrupting you. If you need the message, fine, but have it in a status bar as before but not interrupting the user :)

Reproducible: Always

Steps to Reproduce:
1. Drag a folder and drop it onto itself

Actual Results:  
A message “Sorry, you cannot drop a folder on itself“ appears interrupting you

Expected Results:  
Do nothing.

Comment 1 Peter Penz 2011-10-09 14:27:37 UTC

I agree of course but cannot reproduce the issue on master: No message box is interrupting the flow (currently no message is shown at all, which is a known regression). I'll leave this issue open in the meaning of "a message should be shown in the statusbar".

Comment 2 Peter Penz 2011-10-11 15:55:57 UTC

Ha, I could reproduce the issue now: It only occurs if the Details View is enabled :-)

Comment 3 Frank Reininghaus 2011-10-13 17:00:23 UTC

I can also reproduce in Icons View, but only if more than one folder is dragged and then dropped on one of the selected folders.

Comment 4 Peter Penz 2011-12-10 20:50:49 UTC

Git commit 2e8cbc4ebdeaf6937f2bdd0b156e15d2a8fdc894 by Peter Penz.
Committed on 10/12/2011 at 21:47.
Pushed by ppenz into branch 'master'.

Show error-message when dropping a folder into itself

Thanks to Janardhan Reddy for the analysis of the issue!

BUG: 283646
FIXED-IN: 4.8.0

M  +4    -1    dolphin/src/views/dolphinview.cpp
M  +7    -4    dolphin/src/views/draganddrophelper.cpp

http://commits.kde.org/kde-baseapps/2e8cbc4ebdeaf6937f2bdd0b156e15d2a8fdc894

Comment 5 Peter Penz 2011-12-10 21:01:12 UTC

@Kai Uwe: The commit message might be missleading - the error message is shown in the statusbar as suggested by you :-)