Summary: | [patch] Determining MIME type of corrupted files hangs on repeated reads | ||
---|---|---|---|
Product: | [Frameworks and Libraries] kdelibs | Reporter: | Miroslav Ľos <milamby> |
Component: | kdecore | Assignee: | kdelibs bugs <kdelibs-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | faure, peter.penz19 |
Priority: | NOR | ||
Version: | 4.7 | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 4.7.3 | |
Attachments: | proposed patch |
Description
Miroslav Ľos
2011-08-19 21:13:26 UTC
Created attachment 62988 [details]
proposed patch
Gentoo won't tether. Android browser won't upload files.
Waiting times after my fix are comparable to those in Nautilus (Ubuntu).
Thanks a lot for the patch! Could you please put the patch to https://git.reviewboard.kde.org and put faure@kde.org to the recipients-list? I'm quite sure that this patch will be "forgotten" here in bugs.kde.org within hundreds of other reports - on git.reviewboard.kde.org it usually takes only a few days until the patch can get committed. Well, I registered and created a review request (102382), but uploading a patch to the system seems to require the correct commit hashes, which in turn requires a git clone of the lot of kdelibs, which is not so great over my current connection. I believe Mr. Faure could apply the patch as-is in his environment. I have confirmed it will apply cleanly to the current master. Sorry for the inconvenience (mine would be greater). No problem, I've created a review request on https://git.reviewboard.kde.org/r/102391/ and will take care to push it if David found the time to review it. Thanks. I have commented in the review request. Would the problem be fixed for you without the use of Unbuffered? (Alternatively we could make sure to always update the cache, in the code, when reading data after the current cache size, and then we could use Unbuffered) Git commit 880a4e8512343462353f69ddecb63ae1748b9902 by Peter Penz. Committed on 20/08/2011 at 19:14. Pushed by ppenz into branch 'KDE/4.7'. Don't hang when determining MIME type of corrupted files The patch has been provided by Miroslav Ľos. BUG: 280446 M +8 -0 kdecore/services/kmimetyperepository.cpp M +2 -2 kdecore/services/kmimetype.cpp http://commits.kde.org/kdelibs/880a4e8512343462353f69ddecb63ae1748b9902 Git commit 7705b25883c76affcc608e157e0d003de98ad531 by Peter Penz. Committed on 20/08/2011 at 19:14. Pushed by ppenz into branch 'KDE/4.7'. Don't hang when determining MIME type of corrupted files The patch has been provided by Miroslav Ľos. BUG: 280446 M +8 -0 kdecore/services/kmimetyperepository.cpp M +2 -2 kdecore/services/kmimetype.cpp http://commits.kde.org/kdelibs/7705b25883c76affcc608e157e0d003de98ad531 Sorry, I accidentally have pushed the patch. I had some troubles with the history then in git (-> 2 commits listed here) but the patch is reverted now. Git commit 6606337b9bdf98111276d0fd3d803a644462cb28 by David Faure. Committed on 19/10/2011 at 09:35. Pushed by dfaure into branch 'KDE/4.7'. Read the first 16K of the file upfront, to minimize seeks and reads. Patch by Miroslav Ľos - thanks! BUG: 280446 FIXED-IN: 4.7.3 REVIEW: 102391 M +8 -0 kdecore/services/kmimetyperepository.cpp http://commits.kde.org/kdelibs/6606337b9bdf98111276d0fd3d803a644462cb28 |