Bug 277231

Summary: Rewrite all the key input handling code in chat UI
Product: [Frameworks and Libraries] telepathy Reporter: David Edmundson <kde>
Component: text-uiAssignee: Telepathy Bugs <kde-telepathy-bugs>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: 0.4.0   
Platform: Unlisted Binaries   
OS: Linux   
Latest Commit: Version Fixed In:

Description David Edmundson 2011-07-06 19:37:14 UTC 
Version:           unspecified
OS:                Linux

Right now it's a confusing mess, the text box overrides the keyInputEvent() and ChatWidget has an eventFilter on the textBox.

There are also using signals/slots when they should be using event propogation. 

This is a reminder to do a big cleanup after the first release.
Assigned to d_ed.

Reproducible: Didn't try

Steps to Reproduce:
N/A


Expected Results:  
N/A
Comment 1 David Edmundson 2011-10-20 23:35:18 UTC 
Git commit e8df9c842805dd449704f85cb8e8ab23c6341d5b by David Edmundson.
Committed on 18/10/2011 at 21:20.
Pushed by davidedmundson into branch 'master'.

Tidy up all key handling code.

Remove signals and slots, and use event propogation where it makes more sense to pass events to parents.

REVIEW: 102908
BUG: 277231
BUG: 284531

M  +0    -5    lib/adium-theme-view.cpp
M  +0    -1    lib/adium-theme-view.h
M  +30   -6    lib/chat-text-edit.cpp
M  +2    -3    lib/chat-text-edit.h
M  +14   -9    lib/chat-widget.cpp
M  +0    -1    lib/chat-widget.h

http://commits.kde.org/telepathy-text-ui/e8df9c842805dd449704f85cb8e8ab23c6341d5b