Summary: | Skype plugin duplicates messages in conferences | ||
---|---|---|---|
Product: | [Applications] kopete | Reporter: | Radosław Jan Ganczarek <dreamwalker> |
Component: | Skype Plugin | Assignee: | Pali Rohár <pali.rohar> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | a.j.ball, btsai, Chain, gurnaikv, ignatius, juan.baptiste, j_kanev, mail, pali.rohar, vo.zaeb |
Priority: | NOR | ||
Version: | 1.0.80 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kopete/0a53d7868b057e1b4d5a3f10a6115ce82e3bbfa2 | Version Fixed In: | 4.11 |
Attachments: | Patch for reverting revision 1133818 |
Description
Radosław Jan Ganczarek
2011-04-19 09:32:19 UTC
I suffer from this, too. KDE 4.6.80 but in 4.6 I've had the same. The strange thing is that it happens not for all my skype contacts. And also for me it happens and in one to one chats. even if I'll open native skype chat window and send message from it, kopete still display duplicates. Also happens with kopete version from KDE 4.5.5, but I don't remember having this problem with skype 2.1.0.81, just since I upgraded to 2.2.0.25. This is happening for me in KDE 4.6.4 (64bit): duplicate messages even in one-to-one Skype (2.2.0.35) chats. Same issue, intermittently double posts same chat message, when using kopete chat window for Skype chat. openSUSE 11.4, Kopete 1.0.80 (KDE 4.6.0), Skype 2.2.0.35 dynamically linked version. I think that problem appeared in this commit: http://websvn.kde.org/?view=revision&revision=1133818 Can somebody compile and try Kopete before this commit? Okay, will try to :) @Richard Homonnai: Did you tried it? Didn't have any luck. I kind of destroyed my Qt and stopped than, after that I forgot about it. So let's try again. :) could someone please tell me the command to check out the right revision? Due to the Git migration I cannot find any information it seems... kopete is still on svn. command to checkout revision before 1133818: $ svn co -r 1133817 svn://anonsvn.kde.org/home/kde/trunk/KDE/kdenetwork/kopete CCing Benson Tsai, author of patch in commit 1133818. @Benson Tsai: Can you test if you have this problem too? @Richard Homonnai: Did you tested kopete version before 1133818? (In reply to comment #12) > @Richard Homonnai: > Did you tested kopete version before 1133818? Hi, I tried. a lot. But I just cannot compile it, using KDE 4.7.3. I am getting compile errors over and over. I seem to have fixed these now (it was about visibility) but now I have problems about videodev.h, which seems to be named otherwise on my system. In short, I am working on it :) @Richard Homonnai: Any news? (In reply to comment #14) > @Richard Homonnai: > Any news? Hi, Sorry, I tried it multiple times, it's not easy to build unfortunately. Yesterday I started again from scratch. I have almost built it. But now I get headaches about videodev.h in libkopete - is there a way to exclude video devices also? For disabling video use cmake param DISABLE_VIDEOSUPPORT cmake -DDISABLE_VIDEOSUPPORT=ON Thank you that worked. I have Kopete built now. So far, no duplicate messages. Trying for a few days... (using it instead of the new Kopete in 1.1.3, this is 1.0.80) Created attachment 69536 [details]
Patch for reverting revision 1133818
Ok, so if you are using kopete rev. 1133817 and there is no problem with duplicate messages, can you also try to last kopete from svn without patch introduced in revision 1133818? I attached patch against kopete trunk which revert revision 1133818. Apply it with patch -p2 -i <file>
Unfortunately, no. I was chatting with the 1133817 revision the whole day, didn't get a single duplicated line, so I tried trunk + patch - it did work for a long while. And then it happened again. However, in the last updates the duplicate messages were getting less it seems. I looked through my logs. When I posted my first reply, almost every message I sent was duplicated. By now, only single ones - maybe some race condition. I will now revert to 1133817 - and tell you if it is still happening. As it seems, this commit is not the bad boy itself. No, the old version seems to have the same effect. It just happens from time to time. It's hard to track because at most times it seems to work now. Also, there is nothing visible, even with all debug output turned on. It's just... strange. It worked for like 6 hours, nothing happened. And then, out of nowhere, it started again. and it also stopped, just like it started. I really have no clue what it is. But it does not seem to make any difference whether the patch is there or not (maybe the probability of getting duplicates is different, though). Tomorrow I'll try it with the 4.7.4 version again and see if there are more occurences. Additional information (on debian sid): Message duplicating happens in 80% of cases, with no apparent cause. Message duplicating is independent of number of participants (happens in one-one chats as well). In Kopete window only my messages are duplicated, not those of the other participant(s). Kopete history plugin shows my messages duplicated as well. Skype history (opened in skype directly) shows messages from the same chant non-duplicated. Git commit 0a53d7868b057e1b4d5a3f10a6115ce82e3bbfa2 by Pali Rohár. Committed on 07/06/2013 at 23:05. Pushed by pali into branch 'master'. Fix skype protocol code which was incorrectly ported to KDE4 * Fix some missing calls to trimmed() string function * Fix incorrect handling of duplicate skype messages * This is propably root problem of bug 271277 M +7 -7 protocols/skype/libskype/skype.cpp M +1 -1 protocols/skype/skypeaccount.cpp http://commits.kde.org/kopete/0a53d7868b057e1b4d5a3f10a6115ce82e3bbfa2 @j_kanev, @Richard: Can you test if this bug still occured? It is still very real, and very annoying, and hard to pinpoint. I will try your patch against 4.10.3 the next days :) The patch applied cleanly with Kopete 4.10.3 (using gentoo with userpatches) testing it now for a few days. It might take a while because this just happens (or happened) sometimes... Actually... this patch seems to fix quite some more of my skype problems, in particular, that some messages are never displayed in Kopete, when I receive them in Skype. Sending takes longer instead of being instantly shown - I guess this is because Skype does not acknowledge the receipt of it. This is quite fine for me however. I think I never reported that bug, but I will search for it. No groupchat so far, so I will have to wait for the other issue though. Ok, so is git commit 0a53d7868b057e1b4d5a3f10a6115ce82e3bbfa2 fixing this bug? Also note that kopete skype plugin supports only skype client 2.x versions (old and new could not work correctly). It seems to be fixed. The sending delay vanished a reboot later, but not important for this bug. I am using Skype 4.2.0.11 by the way, it does not give me any real problems. Just sometimes it needs to long for startup, and the plugin times out. But a reconnect fixes that. Sometimes I get no contacts, sometimes not all of them, but again a reconnect fixes that. Just for a short notice. Oh, and DON'T use the button to set the preferences of Skype. It won't start until you delete your XML file. I will watch for the duplication for some time and report it, if it happens. So far, all is good. Ok, if this duplicate messages bug returns back, reopen it. Now I close it as fixed. That button for setting preferences is for Skype 2.x, so it is normal that for new 4.x not working... |