Bug 267201

Summary:	rekonq can't open .html files over the tar-kioslave
Product:	[Applications] rekonq	Reporter:	Heinz Wiesinger <pprkut>
Component:	general	Assignee:	Andrea Diamantini <adjam7>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	latest git snapshot
Target Milestone:	0.7
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:

Description Heinz Wiesinger 2011-02-26 21:12:13 UTC

Version:           latest git snapshot (using KDE 4.5.5) 
OS:                Linux

When trying to open a html-file over the tar-kioslave, I get a dialog asking me whether to cancel, save it or open it with konqueror.
When changing the mime type association from konqueror to rekonq, rekonq would fall into an infinite loop trying to open the file in a new tab (thus creating ever new tabs until you kill it)

Reproducible: Always

Comment 1 Andrea Diamantini 2011-02-27 09:38:41 UTC

I have a clear idea of what part of code permits this broken behavior, but no clear idea on how to fix it...
Did you test this behavior locally or you have an example site to?

Comment 2 Heinz Wiesinger 2011-02-27 10:14:36 UTC

well, afaik the tar-kioslave only works with files on the local filesystem, so it's kinda hard to provide a remote testcase :)
But it should pretty much work with any tar archive out there that contains html files. Just go into the archive with dolphin/krusader/whatever app can use the tar-kioslave and try to open the html file from there.

Comment 3 Andrea Diamantini 2011-02-27 10:26:38 UTC

You can easily note I'm new to this tar-ioslave feature :)

PS: sure it works just locally? At a first glance, I cannot understand what could be the limitations..

Comment 4 Andrea Diamantini 2011-03-03 12:08:50 UTC

Git commit 6f36358bd4ffd696b2e627b92e74ed302fb22e7f by Andrea Diamantini.
Committed on 03/03/2011 at 12:04.
Pushed by adjam into branch 'master'.

Clean up the "rekonq handling chain" to work as:

1. preHandling: about, javascript, abp protocols. Stops if protocol is NOT known
2. WebKit handling: Allow WebKit to try doing its job
3. postHandling / unsupported content handling: try what is possible to let users see it :)

This also prevents some possible infinite loop on opening...
BUG:267201

M  +8    -28   src/protocolhandler.cpp     
M  +10   -18   src/webpage.cpp     

http://commits.kde.org/rekonq/6f36358bd4ffd696b2e627b92e74ed302fb22e7f