Summary: | importing a RAW picture results in empty view | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | S. Burmeister <sven.burmeister> |
Component: | Plugin-RawImport-Native | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | caulier.gilles, marcel.wiesweg |
Priority: | NOR | ||
Version: | 2.0.0 | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 2.0.0 |
Description
S. Burmeister
2011-01-06 14:43:16 UTC
Yes, i confirm. Gilles Caulier The problem is this line in slotRawLoadFromTool: if (!rawImport->demosaicingSettingsDirty()) which returns false. It also does not work if the raw preview was never generated. Don't know what went wrong here SVN commit 1212333 by mwiesweg: Fix comparison. Because of this bug, the following always failed: DRawDecoding a = b; if (a == b) { ... } // returned false BUG: 262303 M +1 -1 loadingdescription.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1212333 Not sure whether this is related but if you click on "import" while digikam is still calculating the import preview in the image editor you still get an empty view. Good point. Gilles, currently the check is if the "Update" button of raw settings is enabled. We need to check if a) the button is disabled AND b) no filter is running? Or a bool dirty flag? Well, the Import button must be disabled until computation is working. Why ? because the image imported will be the one computed in rawimport tool for preview. Remember that old behavior been to recompute the image when import is pressed, because preview image been a reduced version in all case. Now it's different, due to a lack of preview for some important options to decode raw has demosicing method, which has no effect in half preview extraction. I think this problem exist too into trunk (1.8.0), because i not tested this case, if i remember. Swen, can you confirm this ? Gilles Caulier Open a RAW image. The image is being loaded, the Update button is disabled - all right. Now you click on Import. Check and conclusion is: "button is disabled => image is ready". But it is not, there is no image, it is still being loaded. Do you see this message on the console : Object::connect: No such signal Digikam::RawSettingsBox::signalDemosaicingChanged() in /mnt/data/Devel/SVN/branches/digikam/core/utilities/imageeditor/rawimport/rawimport.cpp:105 Gilles |