Summary: | tar:/ kioslave chokes on (some?) tarballs from git archive | ||
---|---|---|---|
Product: | [Frameworks and Libraries] kio | Reporter: | Kevin Kofler <kevin.kofler> |
Component: | tar | Assignee: | David Faure <faure> |
Status: | RESOLVED FIXED | ||
Severity: | critical | CC: | adaptee, jan_lepper, mbensi, rdieter |
Priority: | NOR | ||
Version: | 4.5 | ||
Target Milestone: | --- | ||
Platform: | Fedora RPMs | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 4.8.1 |
Description
Kevin Kofler
2010-12-03 21:49:31 UTC
I just noticed another archive which exhibits the ghost 'pax_global_header' file http://ftp.gnu.org/gnu/libc/glibc-2.14.1.tar.bz2 These days, this also affects several of KDE's own tarballs (even core tarballs of the software compilation), which makes this particularly painful and embarrassing! Mario, do you want to take a look? :-) yes, I can reproduce the bug, next step find a fix. Git commit 262cf5920c9c0d9619d384bcf0298615c2060b44 by Mario Bensi. Committed on 24/02/2012 at 18:08. Pushed by bensi into branch 'KDE/4.8'. Test Global extended header Add a test on Global extended header, if we find the 'g' flag we need to skip the file, the Global extended header shouldn't be appear in the result of read REVIEW: 104065 M +9 -1 kdecore/io/ktar.cpp A +- -- kdecore/tests/global_header_test.tar.bz2 M +19 -0 kdecore/tests/karchivetest.cpp M +1 -0 kdecore/tests/karchivetest.h http://commits.kde.org/kdelibs/262cf5920c9c0d9619d384bcf0298615c2060b44 Git commit 762136bc525d84215bfbcbedc995431e8b66b181 by Mario Bensi. Committed on 24/02/2012 at 18:11. Pushed by bensi into branch 'KDE/4.8'. Test and add prefix value We can have a prefix value in header at 0x159, if the value of the prefix are not null, we need to add this to the name value, with '/' to separate. REVIEW: 104067 M +5 -0 kdecore/io/ktar.cpp M +26 -0 kdecore/tests/karchivetest.cpp M +1 -0 kdecore/tests/karchivetest.h A +- -- kdecore/tests/tar_prefix_test.tar.bz2 http://commits.kde.org/kdelibs/762136bc525d84215bfbcbedc995431e8b66b181 Git commit 6e0d694b302b57883ed79a3b47c9d60bea20dc8e by Mario Bensi. Committed on 24/02/2012 at 18:15. Pushed by bensi into branch 'KDE/4.8'. Test also the prefix value We need to test if there is a prefix value because the file name can be null and the prefix can have a value and in this case we don't reset n. REVIEW: 104068 M +3 -1 kdecore/io/ktar.cpp M +27 -0 kdecore/tests/karchivetest.cpp M +1 -0 kdecore/tests/karchivetest.h A +- -- kdecore/tests/tar_directory_forgotten.tar.bz2 http://commits.kde.org/kdelibs/6e0d694b302b57883ed79a3b47c9d60bea20dc8e Can somebody confirm that https://bugs.kde.org/show_bug.cgi?id=206994 and https://bugs.kde.org/show_bug.cgi?id=290376 are duplicates of this ? Bug #206994 is NOT a duplicate of this bug. |