Bug 258083

Summary: truncated credits in "About" dialog
Product: [Frameworks and Libraries] kdelibs Reporter: Alexander Potashev <aspotashev>
Component: kdeuiAssignee: kdelibs bugs <kdelibs-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: annma, teo
Priority: NOR    
Version: SVN   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: screenshot of About dialog of Lokalize
About Lokalize dialog in French, it expands to fit the strings
Translation tab in Lokalize in French

Description Alexander Potashev 2010-11-27 17:23:22 UTC
Created attachment 53800 [details]
screenshot of About dialog of Lokalize

Version:           SVN (using KDE 4.5.80) 
OS:                Linux

The new About dialog does not wrap strings. See screenshot.

Reproducible: Always
Comment 1 Anne-Marie Mahfouf 2010-11-27 19:57:48 UTC
I cannot reproduce in French, the dialog expands to fit the credits, see screenshot.
Comment 2 Alexander Potashev 2010-11-27 20:00:58 UTC
(In reply to comment #1)
> I cannot reproduce in French, the dialog expands to fit the credits, see
> screenshot.

Did you forget to attach the screenshot?
Comment 3 Anne-Marie Mahfouf 2010-11-27 20:03:12 UTC
Created attachment 53807 [details]
About Lokalize dialog in French, it expands to fit the strings
Comment 4 Anne-Marie Mahfouf 2010-11-27 20:05:38 UTC
Alexander: no! very slow connection!!
Comment 5 Teo Mrnjavac 2010-11-27 20:07:41 UTC
Some slavic languages tend to take a lot of space to express something so I
guess I should have seen this coming.
I'll see if I can implement elision or word wrap, though it won't be easy
because I'm laying out stuff manually in the view's delegate.
Anne-Marie, can you please also check the translators tab? There's a QLabel on its bottom so this might be what makes your dialog wider, not the items' width.
Comment 6 Anne-Marie Mahfouf 2010-11-27 20:18:13 UTC
The label width in Translation tab is inferior in width to the Credits strings.
Maybe the Credit string on Alexander's screenshot is way longer and the French one fits by luck!
In any case it's better to wrap the string if you can.
Comment 7 Anne-Marie Mahfouf 2010-11-27 20:19:58 UTC
Created attachment 53808 [details]
Translation tab in Lokalize in French
Comment 8 Alexander Potashev 2010-11-27 20:36:10 UTC
@annma: may be your dialog is wider because of long tranlation of the KDE SC version string (above the tabbar).
Comment 9 Anne-Marie Mahfouf 2010-11-27 20:47:31 UTC
@Alexander: yes you are right indeed, it's the dialog title which is long and thus determines the dialog width
Comment 10 Teo Mrnjavac 2010-11-27 21:02:47 UTC
Maybe that string should be wrapped as well. Ideally however for the best visual result it would be nice if translators could always keep it on one row and short enough for the dialog not to grow... Not sure if that's too much to ask
Comment 11 Teo Mrnjavac 2010-11-28 21:25:25 UTC
SVN commit 1201822 by mrnjavac:

Many layout fixes in the person list delegate, which allow for long text to be word-wrapped.
CCBUG:258083

 M  +67 -42    kaboutapplicationpersonlistdelegate_p.cpp  
 M  +5 -0      kaboutapplicationpersonlistdelegate_p.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1201822
Comment 12 Teo Mrnjavac 2010-11-28 21:28:14 UTC
Alexander, before I mark this bug as resolved I'd appreciate if you could please confirm if my last commit fixes the issue in your language.
Comment 13 Christoph Feck 2010-11-29 00:34:13 UTC
Wrapping works now. The dialog resizes a bit slow, but I am not sure if that is caused by your commit.
Comment 14 Teo Mrnjavac 2010-11-29 10:18:24 UTC
Not sure, the added complexity isn't that much.