Summary: | Bug (i don't speak english) | ||
---|---|---|---|
Product: | [Applications] umbrello | Reporter: | Michal <stojex> |
Component: | general | Assignee: | Joris Steyn <kde> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | ralf.habacker |
Priority: | NOR | ||
Version: | 2.5.1 | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/umbrello/29dbb0f09e083613f2acbab2ca14cb999149bbad | Version Fixed In: | 4.11.4 |
Description
Michal
2010-11-21 19:58:32 UTC
Git commit 8eb9a5457ca292712c75ca5efbc4bf5ff2f88afc by Andi Fischer, on behalf of Joris Steyn. Committed on 23/09/2013 at 17:27. Pushed by fischer into branch 'master'. Fix crash when adding entity constraints The root cause of this crash is not checking for a valid index when retrieving the item from the QList. We should at least check that value before calling at(). The patch I propose adds this check and also fixes the problem causing the index to be wrong in the first place (like Arash Abedinzadeh described). Related: bug 191396, bug 237992, bug 302120, bug 322541 M +12 -11 umbrello/dialogs/classifierlistpage.cpp M +1 -1 umbrello/dialogs/classifierlistpage.h M +9 -0 umbrello/dialogs/constraintlistpage.cpp M +1 -0 umbrello/dialogs/constraintlistpage.h http://commits.kde.org/umbrello/8eb9a5457ca292712c75ca5efbc4bf5ff2f88afc Git commit 29dbb0f09e083613f2acbab2ca14cb999149bbad by Joris Steyn. Committed on 23/09/2013 at 17:27. Pushed by jorissteyn into branch 'KDE/4.11'. Fix crash when adding entity constraints Related: bug 191396, bug 237992, bug 302120, bug 322541 FIXED-IN: 4.11.4 Cherry-picked from 8eb9a5457ca292712c75ca5efbc4bf5ff2f88afc. Conflicts (resolved): umbrello/dialogs/classifierlistpage.cpp M +11 -10 umbrello/dialogs/classifierlistpage.cpp M +1 -1 umbrello/dialogs/classifierlistpage.h M +9 -0 umbrello/dialogs/constraintlistpage.cpp M +1 -0 umbrello/dialogs/constraintlistpage.h http://commits.kde.org/umbrello/29dbb0f09e083613f2acbab2ca14cb999149bbad |