Summary: | Incorrect component selected for KMail2 | ||
---|---|---|---|
Product: | [Applications] drkonqi | Reporter: | Alex Merry <alex.merry> |
Component: | general | Assignee: | Dario Andres <andresbajotierra> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Alex Merry
2010-09-08 13:18:26 UTC
Additionally, we made an assumption that is not completely true now (KMail2 being released with KDE SC 4.5, with the "kmail" internal name; also the product name was "KMail 2", and it was later renamed to "kmail2")... http://websvn.kde.org/trunk/KDE/kdebase/runtime/drkonqi/data/mappings?r1=1076802&r2=1076849 Messy... Too bad that we didn't got advertised of these changes before Hmm, too bad. If I understand right, all that needs to be done is the mapping to be removed, correct Dario? Ah, the mapping list uses the binary name, not the internal name, right? So the mapping needs to be changed, not removed: it should be kmail=kmail2|general Ah yes, it uses KCmdLineArgs::appName(), which returns argv[0]. So this is the correct change. Well.. considering that the default (adviced) KMail for KDE SC 4.5 is still KMail 1 (from KDEPIM 4.4.x), the mapping for the KDE SC 4.5.x series could be removed (so it will match "kmail" (1)) and the mapping in trunk (KDE SC 4.6.x) should be "kmail=kmail2|general". Too bad that a proper version detection system wasn't implemented, but I guess we didn't expect such a version mismatch to happen.... Regards SVN commit 1174401 by gkiagia: Change mapping for kmail2, the bugzilla product is now "kmail2". BUG: 250553 M +1 -1 mappings WebSVN link: http://websvn.kde.org/?view=rev&revision=1174401 SVN commit 1174413 by gkiagia: Remove the kmail2 mapping from the 4.5 branch. This is because kmail 1.x is still the recommended version for 4.5. Of course, if someone uses kmail2 with kde 4.5, this will report crashes to the wrong product, but we can't do much for it... CCBUG: 250553 M +0 -1 mappings WebSVN link: http://websvn.kde.org/?view=rev&revision=1174413 |