Summary: | Confirm before killing apps that are still open after the timeout | ||
---|---|---|---|
Product: | [Plasma] ksmserver | Reporter: | Navid Zamani <navid.zamani> |
Component: | general | Assignee: | Lubos Lunak <l.lunak> |
Status: | RESOLVED DUPLICATE | ||
Severity: | major | CC: | gogetmgus, kollix, nate, tobias |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kde-workspace/7213d2081e0bc8fb4a34f0af9f526da9380b9e95 | Version Fixed In: |
Description
Navid Zamani
2010-08-20 04:23:10 UTC
Git commit e648950adef6bca37c554f586b611006e041d931 by Martin Koller. Committed on 22/08/2012 at 16:49. Pushed by mkoller into branch 'KDE/4.9'. make the client shutdown timeout configurable sometimes the timeout for applications to shutdown is too short, e.g. when running on old hardware, having lots of applications open, browsers with many tabs, etc. This patch adds two config entries with which you can define the timeout before ksmserver kills the apps. In the [General] section of ksmserverrc you can define: legacySaveTimeoutSecs (default = 4 seconds) clientShutdownTimeoutSecs (default = 15 seconds; was 10 before) Related: bug 273326 FIXED-IN: 4.9.1 REVIEW: 106090 M +13 -5 ksmserver/legacy.cpp M +7 -1 ksmserver/shutdown.cpp http://commits.kde.org/kde-workspace/e648950adef6bca37c554f586b611006e041d931 Git commit 7213d2081e0bc8fb4a34f0af9f526da9380b9e95 by Martin Koller. Committed on 22/08/2012 at 16:49. Pushed by mkoller into branch 'master'. make the client shutdown timeout configurable sometimes the timeout for applications to shutdown is too short, e.g. when running on old hardware, having lots of applications open, browsers with many tabs, etc. This patch adds two config entries with which you can define the timeout before ksmserver kills the apps. In the [General] section of ksmserverrc you can define: legacySaveTimeoutSecs (default = 4 seconds) clientShutdownTimeoutSecs (default = 15 seconds; was 10 before) Related: bug 273326 FIXED-IN: 4.9.1 REVIEW: 106090 M +13 -5 ksmserver/legacy.cpp M +7 -1 ksmserver/shutdown.cpp http://commits.kde.org/kde-workspace/7213d2081e0bc8fb4a34f0af9f526da9380b9e95 We misunderstood each other.
The purpose of this bug, as opposed to 273326, was that
> ksmserver should wait longer [done, but not the point of this particular bug], and at the end, when there are still open apps, show a dialog, asking if they should be (something equivalent to) SIGQUIT, -TERM, or -KILLed, or if shutdown should be cancelled [not done].
So I’m re-opening this bug, since creating a new one for that, would rightfully be called a duplicate. :)
Sadly, I can’t write C++. Otherwise this would be what I’d write (in pseudo-code):
runningSessionProcs = … // list of all running processes in the session that we’re exiting from
terminationDelay = … // the optionally configurable delay to wait after sigterm
nextSignalDelay = … // the optionally configurable delay to wait after the timeout warning dialog
nextSignal = null // the next thing the user chose to do with non-exiting processes
for (proc in runningSessionProcs) {
sendSignal(TERM,proc)
}
wait(terminationDelay)
while (runningSessionProcs.length > 0 && nextSignal != IGNORE_AND_CONTINUE_ANYWAY) {
nextSignal = timeoutWarningDialog.prompt() // User gets to choose a signal, to just wait longer, or to ignore things and continue shutting down without doing anything about those processes.
if (nextSignal != IGNORE_AND_CONTINUE_ANYWAY) {
if (nextSignal != null) {
for (proc in runningSessionProcs) {
sendSignal(nextSignal,proc)
}
}
wait(nextSignalDelay)
}
}
*** This bug has been marked as a duplicate of bug 390515 *** |