Bug 247534

Summary: muon does not exit update dialog if source does not exist
Product: [Applications] muon Reporter: Dirk Sarpe <dns_hmpf>
Component: qaptworkerAssignee: Jonathan Thomas <echidnaman>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed In: 1.0.1

Description Dirk Sarpe 2010-08-12 17:51:54 UTC 
Version:           unspecified (using KDE 4.5.0) 
OS:                Linux

I added 
deb http://cran-mirror.cs.uu.nl/ lucid/
as additional software source.
Muon asks me to reload the sources. After confirming it stays at 99%. Closing the dialog still works, but no error message pops up telling what is wrong.

Of course the address was wrong, aptitude update says:
Feh http://cran-mirror.cs.uu.nl lucid/ Packages
  404  Not Found

The correct address would have been:
deb http://cran-mirror.cs.uu.nl/bin/linux/ubuntu lucid/


Reproducible: Always

Steps to Reproduce:
Add the aforementioned address as software source.

Actual Results:  
Reloading software sources stays at 99%.

Expected Results:  
When reloading software sources the user should be informed that the software source could not be found.

OS: Linux (x86_64) release 2.6.32-24-generic
Compiler: cc
Comment 1 Jonathan Thomas 2010-08-12 18:08:38 UTC 
SVN commit 1162769 by jmthomas:

Signal that we are exiting even if we are exiting in error (since all download errors are queued), otherwise we will never return to the main view and our error queue will never be shown.
BUG:247534
FIXED-IN:1.0.1


 M  +2 -4      worker.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1162769