Bug 245795

Summary:	Change Profile no longer under Settings menu
Product:	[Applications] konsole	Reporter:	Jakub Holý <jakub.holy>
Component:	general	Assignee:	Konsole Developer <konsole-devel>
Status:	RESOLVED FIXED
Severity:	major	CC:	adaptee, jack.gurulian, jakub.holy, richlv, vkrevs, wstephenson
Priority:	NOR
Version:	2.5
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:		Version Fixed In:	4.8

Description Jakub Holý 2010-07-26 16:14:24 UTC

Version:           2.5 (using Devel) 
OS:                Linux

i was really used to change profiles using Settings->Change profile->profile_name

now i have Konsole 2.5 - 4.4.95 (KDE 4.4.95 (KDE 4.5 >= 20100723))

why was that removed? it even helped me with ncurses applications via `screen` -> after changing the profile, the window somehow resetted, and i was able to use the mouse wheel exactly as if the application was just in the konsole window, no `screen`.



Reproducible: Always



Expected Results:  
please add (back) the live profile switcher, it highly useful.

OS: Linux (i686) release 2.6.31.12-0.2-default
Compiler: gcc

Comment 1 Will Stephenson 2010-08-06 11:57:22 UTC

It's a regression.

You can change the profile by right clicking on konsole as a workaround.

Comment 2 Will Stephenson 2010-08-06 14:26:45 UTC

Why have you closed this bug?

Comment 3 Jakub Holý 2010-08-06 14:31:16 UTC

i thought regression means "step back" in this context, ... so noone thinks its useful and will fix it... i missed the note about major=1 ... sorry

Comment 4 Kurt Hindenburg 2011-03-03 20:01:35 UTC

It was remove when the menu restructure happened.

Comment 5 Jekyll Wu 2011-07-30 22:13:17 UTC

*** Bug 268522 has been marked as a duplicate of this bug. ***

Comment 6 Jekyll Wu 2011-08-04 12:19:01 UTC

*** Bug 248994 has been marked as a duplicate of this bug. ***

Comment 7 Jack Gurulian 2011-08-04 12:39:42 UTC

(In reply to comment #1)
> It's a regression.
> 
> You can change the profile by right clicking on konsole as a workaround.

No you can not! Try using vim with mouse enabled and change profile with right click. It is impossible, so you have to turn off the mouse on option, change profile and enable it again.

Comment 8 Jekyll Wu 2011-08-28 04:09:19 UTC

It is easy to re-add. But I think there are 2 issues to consider:

1). Should it still be put under 'Settings'?  It is a temporary operation which is applied only to current session. However, putting it under 'Edit' or 'View' do not sounds any better.

2). Should it really be named as 'Change profile'? That 'Change' might be misunderstood as 'Modify'. I think 'Switch Profile' or something similar is clearer.

Comment 9 Jakub Holý 2011-08-29 08:50:46 UTC

1) i guess View should be OK - most of the profile switching is about how can you see the terminal. i does not change the environment so much.
however, in profile settings could be some  option like "switch to this profile now"

2) `switch` is perfect for me (but i use CZ locale...)

Comment 10 Jekyll Wu 2011-09-24 21:25:35 UTC

Git commit 989033462f9f018dba1b17929e375bbc26808c58 by Jekyll Wu.
Committed on 24/09/2011 at 23:20.
Pushed by jekyllwu into branch 'master'.

Refine the 'Change profile' action.

- Rename it into 'Switch Profile' to avoid potential confusion.
- Also put it under the 'Settings' menu.

TODO: rename related methods which use 'change' in their names.

BUG: 245795
FIXED-IN:4.8
REVIEW: 102686

M  +4    -4    desktop/partui.rc
M  +4    -3    desktop/sessionui.rc
M  +2    -2    src/SessionController.cpp

http://commits.kde.org/konsole/989033462f9f018dba1b17929e375bbc26808c58