Summary: | Importing table from mysql local database | ||
---|---|---|---|
Product: | [Applications] KEXI | Reporter: | Dainis <dainisp> |
Component: | General | Assignee: | Adam Pigg <adam> |
Status: | CLOSED FIXED | ||
Severity: | crash | CC: | kde, renszarv07, staniek |
Priority: | NOR | ||
Version: | 2.2.0 (KOffice 2.2.0) | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | New crash information added by DrKonqi |
Description
Dainis
2010-06-23 05:31:53 UTC
#7 0xb1d99531 in KexiMigration::KexiMigrate::connectSource() () from /usr/lib/libkeximigrate.so.7 #8 0xb1dabcdf in KexiMigration::ImportTableWizard::arriveTableSelectPage() () from /usr/lib/libkeximigrate.so.7 #9 0xb1dac4c8 in KexiMigration::ImportTableWizard::slot_currentPageChanged( Please install koffice debuginfo packages and paste a new backtrace Actualy kexi crashed in a moment when i press next second time because when first time it not crashes, but there is no tables in the list. Then i press back , and next second time, then kexi crashes I mean something wrong hapens when i press next in first time ... (sorry for bad english) Created attachment 55434 [details]
New crash information added by DrKonqi
kexi (2.2.2 (KOffice 2.2.2)) on KDE Platform 4.5.1 (KDE 4.5.1) using Qt 4.7.0
- What I was doing when the application crashed:
I've tried to import from a mysql database
-- Backtrace (Reduced):
#7 0x00007fe569e9b435 in KexiMigration::ImportTableWizard::arriveTableSelectPage() () from /usr/lib/libkeximigrate.so.7
#8 0x00007fe569e877c6 in KexiMigration::ImportTableWizard::qt_metacall(QMetaObject::Call, int, void**) () from /usr/lib/libkeximigrate.so.7
[...]
#10 0x00007fe5806f9b58 in KPageDialog::currentPageChanged (this=0x1e33e30, _t1=0x1cfbdb0, _t2=0x1bacbc0) at ./kpagedialog.moc:88
#11 0x00007fe5806f9ba6 in KPageDialog::qt_metacall (this=0x1f01fa0, _c=QMetaObject::InvokeMetaMethod, _id=<value optimized out>, _a=0x7fffd9ecb340) at ./kpagedialog.moc:75
#12 0x00007fe580605db8 in KAssistantDialog::qt_metacall (this=0x1e33e30, _c=28294688, _id=28670721, _a=0x0) at ./kassistantdialog.moc:70
Thnaks! Assigned to A. Pigg. commit 47c4737a59ecd73533d9d241345763a533b0659d branch master Author: Adam Pigg <adam@piggz.co.uk> Date: Sun Jan 2 20:58:41 2011 +0000 Dont crash if no table was selected to import. BUG: 242556 diff --git a/kexi/migration/importtablewizard.cpp b/kexi/migration/importtablewizard.cpp index 288147b..4cffa96 100644 --- a/kexi/migration/importtablewizard.cpp +++ b/kexi/migration/importtablewizard.cpp @@ -497,6 +497,11 @@ bool ImportTableWizard::doImport() return false; } + if (!m_alterSchemaWidget->newSchema()) { + msg.showErrorMessage(i18n("No table was selected to import.")); + return false; + } + KexiPart::Item* partItemForSavedTable = project->createPartItem(part->info(), m_alterSchemaWidget->newSchema()->name()); if (!partItemForSavedTable) { // msg.showErrorMessage(project); Additionally, this patch fixes the crash, but not the fact that no tables were presented for import. This is due to the fact that the mysql driver does not implement this functionality (yet). Perhaps you could open a Wish to keep track of this. I see, the empty list was strange too. I've just setuped the environment, and it seems that in MySQLMigrate::drv_connect returns false, because d->useDatabase(m_migrateData->sourceName) returns false, because m_migrateData->sourceName left empty ! Of course, because there is no database name embedded in the connection data. There should be a 'schema' selector before that table list selector. SVN commit 1213946 by staniek: Migration *Dont crash if no table was selected to import. **backported from 2.4 47c4737a59ecd73533 CCBUG: 242556 M +12 -0 doc/dev/CHANGELOG-Kexi-js M +5 -0 migration/importtablewizard.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1213946 |