Bug 241924

Summary: Data loss bugs: deletes finished downloads, deletes without prompting
Product: [Applications] kget Reporter: Adam Porter <adam>
Component: generalAssignee: KGet authors <kget>
Status: RESOLVED FIXED    
Severity: normal CC: mat69
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed In:

Description Adam Porter 2010-06-16 22:02:04 UTC 
Version:           unspecified (using KDE 4.4.2) 
OS:                Linux

After finishing some downloads in KGet, I clicked "Remove all finished" from the Downloads menu.  KGet then proceeded to delete the finished files from the filesystem.

It also deletes files without prompting if you "Remove selected".

All I wanted to do was clean out the download list.  Now I have to redownload the files.

This is scary.

Reproducible: Always




OS: Linux (x86_64) release 2.6.32-22-generic
Compiler: cc
Comment 1 Adam Porter 2010-06-16 22:02:54 UTC 
Oops, I didn't mean to set severity to normal.  This is serious.
Comment 2 Matthias Fuchs 2010-06-17 12:51:41 UTC 
SVN commit 1139112 by mfuchs:

Do not remove finished files downloaded with metalink if some of the files in the metalink weren't downloaded.
Do not ask the user if he want to overwrite a file selected in metalink if it has been downloaded already.
Change the status to stopped if the seleciton of a metalink changes, thus enabling that transfer to start.
CCBUG:241924

 M  +11 -15    metalink.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1139112
Comment 3 Matthias Fuchs 2010-06-17 12:56:13 UTC 
I have the feeling -- can't reproduce -- that this issue is fixed at least with 4.4.4.
The last commit is a corner case you probably weren't affected with.

What downloads were affected? "Normal" (http, ftp, https, ftps), Metalinks or Torrents?
Comment 4 Matthias Fuchs 2010-06-17 13:02:08 UTC 
SVN commit 1139116 by mfuchs:

Foward port r1139112
Do not remove finished files downloaded with metalink if some of the files in the metalink weren't downloaded.
Do not ask the user if he want to overwrite a file selected in metalink if it has been downloaded already.
Change the status to stopped if the seleciton of a metalink changes, thus enabling that transfer to start.
CCBUG:241924

 M  +11 -15    metalink.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1139116
Comment 5 Matthias Fuchs 2010-06-20 03:33:46 UTC 
Just tried with a torrent-file.
Also no issue there, so closing this report.