Summary: | Konqueror crash when change the fonts or manipulating tabs [null ViewExtensionsFactory::handleCurrentIndexChange, DolphinIconsView::currentChanged/DolphinDetailsView::currentChanged] | ||
---|---|---|---|
Product: | [Applications] konqueror | Reporter: | Dimitrios Glentadakis <dglent> |
Component: | general | Assignee: | Konqueror Developers <konq-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | andreas_nordal_4, andresbajotierra, anton.aylward, frank78ac, j.mairboeck, mihai.dontu, peter.penz19 |
Priority: | NOR | Keywords: | investigated |
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Mandriva RPMs | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 4.5.4 | |
Attachments: |
New crash information added by DrKonqi
Proposed patch |
Description
Dimitrios Glentadakis
2010-06-01 19:10:33 UTC
the crash happens whatever change i do in konqueror's settings and i click on [ok] directrly and not on [apply] and after [ok] *** Bug 246589 has been marked as a duplicate of this bug. *** Thanks for the bug reports! It looks like this issue is related to the Dolphin code which is used by Konqueror. Created attachment 49881 [details]
New crash information added by DrKonqi
konqueror (4.4.95 (KDE 4.4.95 (KDE 4.5 >= 20100723))) on KDE Platform 4.4.95 (KDE 4.4.95 (KDE 4.5 >= 20100723)) using Qt 4.6.3
- What I was doing when the application crashed:
This also happens with the adblock component's configure filter thing. I removed a few duplicate filters out of the list. They occoured after I tried to remove an iframe twice because it didn't go away. I had also a DolphinPart tab open (ftp).
-- Backtrace (Reduced):
#7 0xaa58b4e3 in ViewExtensionsFactory::handleCurrentIndexChange (this=0x0, current=..., previous=...) at /usr/src/debug/kdebase-4.4.95/apps/dolphin/src/viewextensionsfactory.cpp:138
#8 0xaa56181d in DolphinIconsView::currentChanged (this=0xf2e01e8, current=..., previous=...) at /usr/src/debug/kdebase-4.4.95/apps/dolphin/src/dolphiniconsview.cpp:359
#9 0xb6a310f4 in QAbstractItemView::qt_metacall (this=0xf2e01e8, _c=QMetaObject::InvokeMetaMethod, _id=20, _a=0xbfd68a24) at .moc/release-shared/moc_qabstractitemview.cpp:238
#10 0xb6bb8e62 in QListView::qt_metacall (this=0xf2e01e8, _c=QMetaObject::InvokeMetaMethod, _id=51, _a=0xbfd68a24) at .moc/release-shared/moc_qlistview.cpp:111
#11 0xb757b152 in KCategorizedView::qt_metacall (this=0xf2e01e8, _c=QMetaObject::InvokeMetaMethod, _id=51, _a=0xbfd68a24) at /usr/src/debug/kdelibs-4.4.95/build/kdeui/kcategorizedview.moc:75
[Comment from a bug triager] From bug 246643: -- Information about the crash: I was in a hurry and I opened Konqueror, entered sftp://some.host.org and without waiting for the login window, I opened a tab. A few moments after the new tab was created, the login window appeared, I entered my credentials and pressed ENTER. That's when it crashed. From bug 256267: - What I was doing when the application crashed: This crash occured while I was trying to drag a tab to reposition it. All the tabs were for local directories - no http(s), no login, - Updated backtrace (KDE SC 4.5.3): [KCrash Handler] #7 0xafc20a13 in ViewExtensionsFactory::handleCurrentIndexChange (this=0x0, current=..., previous=...) at /usr/src/debug/kdebase-4.5.3/apps/dolphin/src/viewextensionsfactory.cpp:138 #8 0xafbf2afd in DolphinDetailsView::currentChanged (this=0x91982b0, current=..., previous=...) at /usr/src/debug/kdebase-4.5.3/apps/dolphin/src/dolphindetailsview.cpp:455 #9 0xb69520f4 in QAbstractItemView::qt_metacall (this=0x91982b0, _c=QMetaObject::InvokeMetaMethod, _id=20, _a=0xbff0f624) at .moc/release-shared/moc_qabstractitemview.cpp:238 #10 0xb699dfc2 in QTreeView::qt_metacall (this=0x91982b0, _c=QMetaObject::InvokeMetaMethod, _id=51, _a=0xbff0f624) at .moc/release-shared/moc_qtreeview.cpp:119 #11 0xafbf5422 in DolphinDetailsView::qt_metacall (this=0x91982b0, _c=QMetaObject::InvokeMetaMethod, _id=51, _a=0xbff0f624) at /usr/src/debug/kdebase-4.5.3/build/apps/dolphin/src/dolphindetailsview.moc:106 *** Bug 246643 has been marked as a duplicate of this bug. *** *** Bug 256267 has been marked as a duplicate of this bug. *** Created attachment 53602 [details]
Proposed patch
The problem is that setFocus() in the view constructor accesses m_extensionsFactory indirectly before it is initialised (that is done at the end of the view constructor). The attached patch should fix this by making sure that the setFocus() call is done after the initialisation.
@Peter: Is it OK to commit this patch, or could the moving of the setFocus() call have other side effects?
In principle, this patch also fixes 257035 - the null pointer check which I've added to fix that one could be removed to save a line of code, but I would rather leave it as it is for additional safety.
@Frank: The patch looks fine and won't have any sideeffects. Thanks! SVN commit 1199276 by freininghaus: In the item view constructors, call setFocus() only after m_extensionsFactory is initialised. This fixes a possible crash in Konqueror when changing the settings or manipulating tabs. CCBUG: 240374 M +3 -1 dolphindetailsview.cpp M +3 -2 dolphiniconsview.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1199276 SVN commit 1199277 by freininghaus: In the item view constructors, call setFocus() only after m_extensionsFactory is initialised. This fixes a possible crash in Konqueror when changing the settings or manipulating tabs. BUG: 240374 FIXED-IN: 4.5.4 M +3 -1 dolphindetailsview.cpp M +3 -1 dolphiniconsview.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1199277 *** Bug 266534 has been marked as a duplicate of this bug. *** |