Summary: | Dialog box too big after choosing "Send to collection" and no resize | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Oceanwatcher <sub> |
Component: | Collections/Local | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | matej, ralf-engels, rindertvonk, unnamedrambler |
Priority: | NOR | ||
Version: | 2.3.0 | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 2.3.2 | |
Attachments: | Screenshot of dialogbox. No possibility to resize. |
Description
Oceanwatcher
2010-05-18 05:16:56 UTC
Hello, Thanks for the bug report! could you please attach a screenshot of the issue? You can take a screenshot by pressing "Print Screen" ("PrtScrn") on your keyboard, OR running the application KSnapshot, which should be installed by default. Thanks, Casey Created attachment 47466 [details]
Screenshot of dialogbox. No possibility to resize.
Thanks! I'll get to work on this. *** Bug 236066 has been marked as a duplicate of this bug. *** commit 3e0e5a86cb4443862a8c5ec334f553539ece4991 Author: Casey Link <unnamedrambler@gmail.com> Date: Sat May 29 17:38:53 2010 -0500 Tweak the layout of the Organize and filename layout dialogs to make them fit in smaller screens. BUG: 238000 diff --git a/src/dialogs/FilenameLayoutDialog.cpp b/src/dialogs/FilenameLayoutDialog.cpp index 9cc1e80..37e92d6 100644 --- a/src/dialogs/FilenameLayoutDialog.cpp +++ b/src/dialogs/FilenameLayoutDialog.cpp @@ -109,6 +109,7 @@ FilenameLayoutDialog::FilenameLayoutDialog( QWidget *parent, bool isOrganizeColl else { //INIT for collection root + filenamePreview->hide(); unsigned int borderColor = static_cast<unsigned int>( KColorScheme( QPalette::Active ).decoration( KColorScheme::HoverColor ).color().rgb() ); collectionRootFrame->setStyleSheet( "\ color: palette( Text );\ diff --git a/src/dialogs/OrganizeCollectionDialog.cpp b/src/dialogs/OrganizeCollectionDialog.cpp index ff2ddac..329f348 100644 --- a/src/dialogs/OrganizeCollectionDialog.cpp +++ b/src/dialogs/OrganizeCollectionDialog.cpp @@ -88,8 +88,6 @@ OrganizeCollectionDialog::OrganizeCollectionDialog( const Meta::TrackList &track // to show the conflict error connect( ui->overwriteCheck, SIGNAL( stateChanged( int ) ), SLOT( slotUpdatePreview() ) ); - connect( this, SIGNAL( updatePreview( QString ) ), ui->previewText, SLOT( setText( QString ) ) ); - connect( ui->ignoreTheCheck, SIGNAL(toggled(bool)), SLOT(slotUpdatePreview()) ); connect( ui->spaceCheck , SIGNAL(toggled(bool)), SLOT(slotUpdatePreview()) ); connect( ui->asciiCheck , SIGNAL(toggled(bool)), SLOT(slotUpdatePreview()) ); diff --git a/src/dialogs/OrganizeCollectionDialogBase.ui b/src/dialogs/OrganizeCollectionDialogBase.ui index 9cf1c57..105f723 100644 --- a/src/dialogs/OrganizeCollectionDialogBase.ui +++ b/src/dialogs/OrganizeCollectionDialogBase.ui @@ -7,8 +7,8 @@ <rect> <x>0</x> <y>0</y> - <width>944</width> - <height>593</height> + <width>791</width> + <height>523</height> </rect> </property> <property name="sizePolicy"> @@ -68,12 +68,27 @@ </item> <item> <widget class="QGroupBox" name="groupBox_2"> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Preferred"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> + </property> <property name="title"> <string>Character Replacement</string> </property> - <layout class="QVBoxLayout" name="verticalLayout_4"> - <item> + <layout class="QGridLayout" name="gridLayout"> + <property name="sizeConstraint"> + <enum>QLayout::SetFixedSize</enum> + </property> + <item row="0" column="0"> <widget class="QCheckBox" name="spaceCheck"> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> + </property> <property name="toolTip"> <string>If checked, convert spaces to underscores.</string> </property> @@ -85,8 +100,52 @@ </property> </widget> </item> - <item> + <item row="4" column="0" colspan="2"> + <layout class="QHBoxLayout" name="_2"> + <item> + <widget class="QLabel" name="textLabel1"> + <property name="text"> + <string>Replace</string> + </property> + <property name="wordWrap"> + <bool>false</bool> + </property> + </widget> + </item> + <item> + <widget class="KLineEdit" name="regexpEdit"> + <property name="toolTip"> + <string>Regular expression</string> + </property> + </widget> + </item> + <item> + <widget class="QLabel" name="textLabel2"> + <property name="text"> + <string>with</string> + </property> + <property name="wordWrap"> + <bool>false</bool> + </property> + </widget> + </item> + <item> + <widget class="KLineEdit" name="replaceEdit"> + <property name="toolTip"> + <string>Character string</string> + </property> + </widget> + </item> + </layout> + </item> + <item row="0" column="1"> <widget class="QCheckBox" name="ignoreTheCheck"> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> + </property> <property name="toolTip"> <string>If checked, postfix artists' names starting with 'The' with ', The'.</string> </property> @@ -98,8 +157,14 @@ </property> </widget> </item> - <item> + <item row="1" column="1"> <widget class="QCheckBox" name="asciiCheck"> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> + </property> <property name="toolTip"> <string><!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" "http://www.w3.org/TR/REC-html40/strict.dtd"> <html><head><meta name="qrichtext" content="1" /><style type="text/css"> @@ -125,8 +190,14 @@ p, li { white-space: pre-wrap; } </property> </widget> </item> - <item> + <item row="1" column="0"> <widget class="QCheckBox" name="vfatCheck"> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> + </property> <property name="toolTip"> <string>Replace characters that are incompatible with MS-DOS/VFAT file systems with underscores. @@ -142,57 +213,6 @@ Most people can leave this option enabled as it ensures copying to media devices </property> </widget> </item> - <item> - <spacer name="verticalSpacer"> - <property name="orientation"> - <enum>Qt::Vertical</enum> - </property> - <property name="sizeHint" stdset="0"> - <size> - <width>20</width> - <height>47</height> - </size> - </property> - </spacer> - </item> - <item> - <layout class="QHBoxLayout" name="_2"> - <item> - <widget class="QLabel" name="textLabel1"> - <property name="text"> - <string>Replace</string> - </property> - <property name="wordWrap"> - <bool>false</bool> - </property> - </widget> - </item> - <item> - <widget class="KLineEdit" name="regexpEdit"> - <property name="toolTip"> - <string>Regular expression</string> - </property> - </widget> - </item> - <item> - <widget class="QLabel" name="textLabel2"> - <property name="text"> - <string>with</string> - </property> - <property name="wordWrap"> - <bool>false</bool> - </property> - </widget> - </item> - <item> - <widget class="KLineEdit" name="replaceEdit"> - <property name="toolTip"> - <string>Character string</string> - </property> - </widget> - </item> - </layout> - </item> </layout> </widget> </item> @@ -229,35 +249,6 @@ Most people can leave this option enabled as it ensures copying to media devices </widget> </item> <item> - <widget class="QLabel" name="previewText"> - <property name="sizePolicy"> - <sizepolicy hsizetype="Expanding" vsizetype="Preferred"> - <horstretch>0</horstretch> - <verstretch>0</verstretch> - </sizepolicy> - </property> - <property name="toolTip"> - <string>This is what the file names will look like after renaming.</string> - </property> - <property name="text"> - <string/> - </property> - <property name="wordWrap"> - <bool>false</bool> - </property> - </widget> - </item> - <item> - <widget class="QLabel" name="conflictLabel"> - <property name="text"> - <string/> - </property> - <property name="alignment"> - <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set> - </property> - </widget> - </item> - <item> <layout class="QHBoxLayout"> <item> <spacer name="spacer2_2"> @@ -276,6 +267,16 @@ Most people can leave this option enabled as it ensures copying to media devices </spacer> </item> <item> + <widget class="QLabel" name="conflictLabel"> + <property name="text"> + <string/> + </property> + <property name="alignment"> + <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set> + </property> + </widget> + </item> + <item> <widget class="QCheckBox" name="overwriteCheck"> <property name="toolTip"> <string>If checked, overwrite files of the same name without asking.</string> |