Bug 235047

Summary:	Queued Track's Contextual Menu Entry About DeQueueing is written wrong and misleading.
Product:	[Applications] amarok	Reporter:	Hakan Bayindir <hakan>
Component:	Playlist	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nhn, teo
Priority:	NOR	Keywords:	junior-jobs
Version:	2.3-GIT
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:	2.3.1

Description Hakan Bayindir 2010-04-22 11:13:42 UTC

Version:           2.3.0 (using 4.3.4 (KDE 4.3.4), Debian packages)
Compiler:          cc
OS:                Linux (i686) release 2.6.32-3-686-bigmem

When a track is queued in the playlist, contextual menu still shows queue track entry. While the function of the entry works correctly, entry is misleading.

I'm running debian bundled amarok 2.3.0 without any fancy modifications or add-ons.

How to reproduce:
1- Open Amarok
2- Populate your playlist with your favorite tracks
3- Queue the most favorite of all by
   a- right clicking to song in playlist
   b- selecting "Queue track" and left clicking it.
4- Change your mind and dequeue it by:
   a- right clicking to queued track in playlist
   b- since there's no dequeue track option, left click to queue track again to try
   c- viola! you both reproduced the bug and dequeued the song.

Expected Behavior
1- Open Amarok
2- Populate your playlist with your favorite tracks
3- Queue the most favorite of all by
   a- right clicking to song in playlist
   b- selecting "Queue track" and clicking it.
4- Change your mind and dequeue it by:
   a- right clicking to queued track in playlist
   b- selecting "Dequeue track" and left clicking it.

Comment 1 Sven Krohlas 2010-04-22 11:51:32 UTC

I'm very sure this has been reported before, but I'm unable to find the dupe.

Comment 2 Mark Kretschmann 2010-04-23 08:05:58 UTC

commit 439a7198061cc587b113a23e4ecf0eb1eac4bf65
Author: Nikhil Marathe <nsm.nikhil@gmail.com>
Date:   Fri Apr 23 11:17:51 2010 +0530

   Fixed BUG: 235047 - Queued track's contextual menu entry about dequeuing is wrong and misleading.

   The problem was that the action was only being created once with the text, depending on the Queued state of the track that was queued/dequeued the first time. The next time onwards, the action was reused, but its text wasn't being updated. This fixes it