Summary: | Pasting an image created on the clipboard with PrintScrn results in wrong file permissions | ||
---|---|---|---|
Product: | [I don't know] kde | Reporter: | Nikos Chantziaras <realnc> |
Component: | clipboard | Assignee: | David Faure <faure> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | andresbajotierra, faure, kdelibs-bugs, peter.penz19, samuel.brack |
Priority: | NOR | ||
Version: | 4.5 | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 4.7 |
Description
Nikos Chantziaras
2010-03-20 15:16:19 UTC
- Which application are you using to take the screenshot ? KSnapshot ? Regards (In reply to comment #1) > - Which application are you using to take the screenshot ? KSnapshot ? > Regards No, I'm using the built-in functionality of KDE. The default shortcut in Ctrl+Print. I guess it's KWin that takes the screenshot since in the "Global Keyboard Shortcuts" section of System Settings, it's listed as a "KWin" shortcut. No one can dedicate 10 seconds of his time to try and reproduce? I could confirm the issue. Confirmed in 4.5, changing component to clipboard. Not only 4.5, it's still a problem in 4.6. Updated from 4.6 RC2 to 4.6 final. Issue still there. But still there in KDE 4.6.2. OK, this is because kio/paste.cpp's pasteDataAsyncTo writes into a tempfile, and then moves the temp file to the final location [so that it works for remote urls too]. Since this creates other issues too (undo moves back to the tempfile!), I think I'll need to rework all this to be a "put job" instead. Git commit 2d37dbf9bc4e66611b59aedc2144363aeee5a27f by David Faure. Committed on 19/04/2011 at 22:44. Pushed by dfaure into branch 'master'. Implement pasting of data with storedPut rather than moving a tempfile. This fixes the wrong permissions on the created file, and will make it possible to fix undo too (not done yet). Had to deprecate methods that return a CopyJob pointer, but the main method pasteClipboard is unchanged. Old QT_NO_MIMECLIPBOARD code removed, unmaintainable and wrong. BUG: 231420 FIXED-IN: 4.7 M +88 -68 kio/kio/paste.cpp M +22 -6 kio/kio/paste.h http://commits.kde.org/kdelibs/2d37dbf9bc4e66611b59aedc2144363aeee5a27f Thanks, David. Any chance for a fix for 4.6? Nope, too intrusive. |