Bug 230645

Summary: plasmapkg doesn't work for languages in which package types have capital letters
Product: [Plasma] plasma4 Reporter: Eckhart Wörner <ewoerner>
Component: generalAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: agostinelli, aseigo, asraniel
Priority: NOR Keywords: junior-jobs
Version: unspecified   
Target Milestone: ---   
Platform: Debian testing   
OS: Unspecified   
Latest Commit: Version Fixed In:

Description Eckhart Wörner 2010-03-14 03:03:21 UTC
Version:            (using KDE 4.4.1)
Installed from:    Debian testing/unstable Packages

If a package type translation contains a capital letter, like "Plasmoid", plasmapkg fails to interpret it correctly.

main.cpp:

const QString type = args->getOption("type").toLower();
[...]
if (type == i18n("plasmoid") || type == "plasmoid") {

The error is in the assumption that i18n("plasmoid") is lowercase (same applies to all other types as well).
Comment 1 Matteo Agostinelli 2010-06-17 10:34:06 UTC
Fixed in r1139060