Bug 228922

Summary:	Lyrics window size too small after edit
Product:	[Applications] amarok	Reporter:	George Baltz <GeoBaltz>
Component:	general	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	Screenshot showing teeny lyrics window

Description George Baltz 2010-02-28 18:03:06 UTC

Version:           2.2-GIT (using KDE 4.3.5)
Compiler:          gcc 4.4.1 
OS:                Linux
Installed from:    openSUSE RPMs

After editing song lyrics (in this case changing to just "Instrumental") the lyrics window is re-sized to just one line, and remains that way for succeeding tracks - see attached screenshot.

Comment 1 George Baltz 2010-02-28 18:08:26 UTC

Created attachment 41209 [details]
Screenshot showing teeny lyrics window

Edited previous track's lyrics to one line ("Instrumental"), now window is too small.

Comment 2 Myriam Schweingruber 2010-02-28 18:23:03 UTC


*** This bug has been marked as a duplicate of bug 222260 ***

Comment 3 George Baltz 2010-02-28 23:53:53 UTC

On Sunday 28 February 2010 12:23:04 pm Myriam Schweingruber wrote:
> https://bugs.kde.org/show_bug.cgi?id=228922
> 
> 
> Myriam Schweingruber <myriam@kde.org> changed:
> 
>            What    |Removed                     |Added
> ---------------------------------------------------------------------------
> - Status|UNCONFIRMED                 |RESOLVED
>          Resolution|                            |DUPLICATE
> 
> 
> 
> 
> --- Comment #2 from Myriam Schweingruber <myriam kde org>  2010-02-28
>  18:23:03 ---
> 
> 
> *** This bug has been marked as a duplicate of bug 222260 ***
> 
Are you sure this is a dupe??  The problem still exists in the current GIT 
source, and the other one is marked resolved.

Comment 4 Rick W. Chen 2010-03-01 02:34:24 UTC

commit 082871876cc10d938ca325daf31c338ad706d059
Author: Rick W. Chen <stuffcorpse@archlinux.us>
Date:   Mon Mar 1 07:00:10 2010 +1300

    lyrics applet: disable collpasing for now
    
    Previously [0fb44c2], the lyrics applet is stopped from collpasing to a
    suitable size when data is updated (because of weird behaviour with kde
    4.4/qt 4.6). But when editing or changing the lyrics font, the applet is
    still collapsed, causing new lyrics on track change to still use the old
    size. This disables all the collapsing for now.
    
    BUG: 228922

diff --git a/ChangeLog b/ChangeLog
index 20bc152..f439ad8 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -28,6 +28,7 @@ VERSION 2.3
       last check.
 
   BUGFIXES:
+    * Fixed lyrics window size too small after edit. (BR 228922)
     * Fixed odd behaviour when doing drag-and-drop from Collection browser.
       (BR 222500)
     * Show artist and title instead of raw track ID when copying/deleting
diff --git a/src/context/applets/lyrics/LyricsApplet.cpp b/src/context/applets/lyrics/LyricsApplet.cpp
index 55d41af..49574a7 100644
--- a/src/context/applets/lyrics/LyricsApplet.cpp
+++ b/src/context/applets/lyrics/LyricsApplet.cpp
@@ -408,7 +408,7 @@ LyricsApplet::changeLyricsFont()
 
     debug() << "Setting Lyrics Applet font: " << font.family() << " " << font.pointSize();
     // resize with new font
-    collapseToMin();
+    // collapseToMin();
 }
 
 void
@@ -520,7 +520,7 @@ LyricsApplet::setEditing( const bool isEditing )
 {
     m_lyrics->setReadOnly( !isEditing );
     update();
-    collapseToMin();
+    // collapseToMin();
 }