Summary: | Filenames design selector not find the right file name pattern | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Javier G. <jagarni1983> |
Component: | Metadata Editing and Reading | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | unnamedrambler |
Priority: | NOR | ||
Version: | 2.3.0 | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 2.3.2 | |
Attachments: | Visual example (because I don't know how is spelled in english that menu) |
Description
Javier G.
2010-02-06 17:56:38 UTC
Created attachment 40571 [details]
Visual example (because I don't know how is spelled in english that menu)
This is the Filename Layout Chooser. Try adding a space after the dot, that works for me. Which exact Amarok version is this? Oh I forgot the typical info for bug reports, sorry :S Amarok v2.2.2 Thank you for your feedback. Confirmed on 2.2.3-git, it only works with a space after the dot Which dot exactly do you put s space after? Rather, what is the exact format that works? commit dcb764356ffd136c012fd4859c1689b75c1d65db Author: Casey Link <unnamedrambler@gmail.com> Date: Sat May 29 13:28:35 2010 -0500 Escape all special regex characters in the schema of a filename before parsing it. Before, if a user had a special regex char in their filename it would be interpreted in the regex pattern as a special char. BUG: 225743 diff --git a/ChangeLog b/ChangeLog index 9b6ac49..0a43a33 100644 --- a/ChangeLog +++ b/ChangeLog @@ -25,6 +25,8 @@ VERSION 2.3.2-Beta 1 Patch by Richard Longland <rlongland@hotmail.com>. BUGFIXES: + * Filenames with dots (.) and other special RegEx characters will now be + parsed correctly when guessing tags from a filename. (BR 225743) * Align track details dialog's labels to the right as per KDE4's HIG. (BR 234555) * The last.fm service will now only open the wallet on startup if the user diff --git a/src/dialogs/TagGuesser.cpp b/src/dialogs/TagGuesser.cpp index 6008b5d..bd3820d 100644 --- a/src/dialogs/TagGuesser.cpp +++ b/src/dialogs/TagGuesser.cpp @@ -74,7 +74,7 @@ TagGuesser::guess() { if( ( !m_fileName.isEmpty() ) && ( !m_schema.isEmpty() ) ) { - QString regExpr = getRegExpFromSchema( m_schema ); + QString regExpr = getRegExpFromSchema( QRegExp::escape( m_schema ) ); QRegExp fileExpr(regExpr + "\\.(.*)"); QRegExp schemaExpr(regExpr); |