Summary: | Custom stations for last.fm shown as url encoded in playlist | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Vovochka <vovochka13> |
Component: | Playlist | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | lfranchi, nhn, teo |
Priority: | NOR | ||
Version: | 2.3.0 | ||
Target Milestone: | 2.3.0 | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 2.3.1 | |
Attachments: |
screenshot
new screenshot :) |
Description
Vovochka
2010-01-16 06:40:53 UTC
Created attachment 39935 [details]
screenshot
2.3 Bug still exists. Changed version. Can somebody please confirm this? Created attachment 41708 [details]
new screenshot :)
commit 7fc8c8b37d321dce4a8ab506318bb175d77f2c54 Author: Soren Harward <stharward@gmail.com> Date: Sun May 9 21:08:23 2010 -0400 Display extended characters in Last.fm stream names properly Instead of displaying names with HTML-entities for extended characters, display the characters themselves. Examples: "Hüsker Dü" instead of "H%252sker%20D%252" "Mötorhead" instead of "M%246torhead" BUG: 222930 diff --git a/ChangeLog b/ChangeLog index 2be1769..1ca2a1f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -7,6 +7,8 @@ VERSION 2.3.1 CHANGES: BUGFIXES: + * Display extended characters properly in names of Last.fm streams. + (BR 222930) * Cover fetcher: prevent automatic fetcher from setting album's cover if it is done manually during the download. (BR 236839) * File browser: show folders first, files afterwards. Patch by diff --git a/src/services/lastfm/meta/LastFmMeta.cpp b/src/services/lastfm/meta/LastFmMeta.cpp index dba4d20..3183521 100644 --- a/src/services/lastfm/meta/LastFmMeta.cpp +++ b/src/services/lastfm/meta/LastFmMeta.cpp @@ -34,6 +34,7 @@ #include "core/support/Debug.h" #include <QPointer> +#include <QUrl> #include <KSharedPtr> #include <KStandardDirs> @@ -382,9 +383,7 @@ Track::streamName() const QStringList elements = d->lastFmUri.toString().split( '/', QString::SkipEmptyParts ); if( elements.size() >= 2 && elements[0] == "lastfm:" ) { - QString customPart = elements[2]; - customPart = customPart.replace( "%20", " " ); - + QString customPart = QUrl::fromPercentEncoding( elements[2].toUtf8() ); if( elements[1] == "globaltags" ) { |