Summary: | Why k3b-setup in systemsettings | ||
---|---|---|---|
Product: | [Applications] k3b | Reporter: | m.wege |
Component: | K3bSetup | Assignee: | Michał Małek <michalm> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | kdestuff |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 2.1.0 |
Description
m.wege
2009-12-25 11:52:38 UTC
I think this is poorly named as well. It's appears as "Permissions" in systemsettings, but doesn't tell me much. At first I thought of OSX' fix-permissions feature, I was a bit surprised then I opened it and found k3d-setup. I think it do belong in systemsettings, but it needs a much better label. "CD/DVD-burner permissions", "CD/DVD-burners" or something like that. Git commit 127d389fe61c77225eb8efab0c53ddf2ef704fdf by Michal Malek. Committed on 11/09/2011 at 17:56. Pushed by mmalek into branch 'master'. Moved K3bSetup functionality to K3b's config dialog K3bSetup never really belonged to SystemSettings. When user wanted to change device or programs permissions he'd needed to switch to SystemSettings which was not obvious. Hence this settings were moved to K3b settings window. Program permissions can now be changed in a new "Permissions" tab on "Programs" section. Modification of devices permissions has been removed altogether. In all (?) modern systems optical devices belongs to a certain user group (e.g. "cdrom"). If the current user does not belongs to this group, he's offered to add himself to it in "Devices" section of K3b settings window. FEATURE: 220040 FIXED-IN: 2.1.0 GUI: K3bSetup no longer exists M +0 -8 CMakeLists.txt M +1 -0 ChangeLog M +0 -1 config-k3b.h.cmake D +0 -1 k3bsetup/.krazy D +0 -34 k3bsetup/CMakeLists.txt D +0 -5 k3bsetup/Messages.sh D +0 -256 k3bsetup/base_k3bsetup.ui D +0 -18 k3bsetup/k3bsetup D +0 -282 k3bsetup/k3bsetup.cpp D +0 -212 k3bsetup/k3bsetup.desktop D +0 -49 k3bsetup/k3bsetup.h D +0 -320 k3bsetup/k3bsetupdevicesmodel.cpp D +0 -72 k3bsetup/k3bsetupdevicesmodel.h D +0 -74 k3bsetup/k3bsetupprogramsmodel.h M +1 -3 libk3b/projects/k3bcdrecordwriter.cpp M +10 -1 src/CMakeLists.txt A +10 -0 src/helper/CMakeLists.txt R +6 -1 src/helper/k3b.actions [from: k3bsetup/k3bsetup.actions - 097% similarity] R +41 -23 src/helper/k3bhelper.cpp [from: k3bsetup/k3bsetupworker.cpp - 066% similarity] R +15 -11 src/helper/k3bhelper.h [from: k3bsetup/k3bsetupworker.h - 065% similarity] R +6 -8 src/helper/k3bhelperprogramitem.cpp [from: k3bsetup/k3bsetupprogramitem.cpp - 064% similarity] R +13 -15 src/helper/k3bhelperprogramitem.h [from: k3bsetup/k3bsetupprogramitem.h - 051% similarity] M +0 -18 src/k3b.cpp M +0 -1 src/k3b.h M +34 -39 src/k3bsystemproblemdialog.cpp M +4 -2 src/k3bsystemproblemdialog.h M +0 -1 src/k3bui.rc M +7 -33 src/option/k3bdeviceoptiontab.cpp M +1 -4 src/option/k3bdeviceoptiontab.h M +78 -26 src/option/k3bdevicewidget.cpp M +7 -1 src/option/k3bdevicewidget.h R +65 -95 src/option/k3bexternalbinpermissionmodel.cpp [from: k3bsetup/k3bsetupprogramsmodel.cpp - 068% similarity] A +75 -0 src/option/k3bexternalbinpermissionmodel.h [License: GPL (v2+)] M +96 -6 src/option/k3bexternalbinwidget.cpp M +7 -1 src/option/k3bexternalbinwidget.h M +1 -1 src/option/k3boptiondialog.cpp http://commits.kde.org/k3b/127d389fe61c77225eb8efab0c53ddf2ef704fdf |