Bug 218272

Summary:	webshortcuts broken after upgrading KDE 3 to 4 due to decimal in keyword delimiter which krunner doesnt support
Product:	[Plasma] krunner	Reporter:	Martin Steigerwald <Martin>
Component:	general	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	adawit, esigra
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:		Version Fixed In:	4.6
Attachments:	kuriikwsfilterrc with decimal value that krunner doesn't support kuriikwsfilterrc with character/string value that krunner doesn't support

Description Martin Steigerwald 2009-12-11 14:08:23 UTC

Version: (using KDE 4.3.4)
OS: Linux
Installed from: Debian testing/unstable Packages

During writing an article about KDE internas for Linux-Magazin I finally got around tracking the cause of this one.

I upgraded to KDE 4 using my old configuration files on two user accounts. On one I found web shortcuts not to be working in KRunner, while on the other they worked.

Today I found out that web shortcuts started working after I set the delimiter between web shortcut and keyword to a space. But they also continued working after I set it back to a colon again.

So I digged further with export KDEHOME=~/.kde-test to see which configuration file Konqueror writes when I change web shortcut configuration as I didn't found this configuration options in konquerorrc. It turned out to be a file with the obscure name kuriikwsfilterrc.

Now I compared that one with a backup I had:

martin@shambhala:~> diff -u ~/Backup/KDE/share/config/kuriikwsfilterrc ~/.kde/share/config/kuriikwsfilterrc | grep Keyword
-KeywordDelimiter=58
+KeywordDelimiter=:

58 is decimal ASCII value for the colon. Konqueror supports that decimal value. KRunner does not. At least on my system the decimal value was not updated to the character value. Thus web shortcuts did not work in KRunner.

There are the following update markers in the configuration file:

martin@shambhala:~/.kde/share/config> head -2 kuriikwsfilterrc
[$Version]
update_info=kuriikwsfilter.upd:post-kde3.1/cvs

The other user did not have this problems, cause web shortcut configuration was not customized:

ms@shambhala:~/.kde/share/config> cat kuriikwsfilterrc
[$Version]
update_info=kuriikwsfilter.upd:post-kde3.1/cvs
ms@shambhala:~/.kde/share/config>

Expected results:

Obviously web shortcuts work in KRunner after updating from KDE 3 with customized web shortcut configuration. Either by having KRunner deal with decimal values in that configuration key, or by having the decimal value replaced with a character value, e.g. 58 => :, on update.

Comment 1 Martin Steigerwald 2009-12-11 14:12:09 UTC

Created attachment 38988 [details]
kuriikwsfilterrc with decimal value that krunner doesn't support

web shortcuts won't work in KRunner, but will work in Konqueror with that file

Comment 2 Martin Steigerwald 2009-12-11 14:14:37 UTC

Created attachment 38989 [details]
kuriikwsfilterrc with character/string value that krunner doesn't support

web shortcuts will work in KRunner and in Konqueror with that file

Comment 3 Dawit Alemayehu 2010-11-28 05:43:07 UTC

(In reply to comment #2)
> Created an attachment (id=38989) [details]
> kuriikwsfilterrc with character/string value that krunner doesn't support
> 
> web shortcuts will work in KRunner and in Konqueror with that file

Neither KRunner nor any other application for that matter has any business reading the configuration file of an unrelated component. kuriikwsfilrterrc is not a global configuration file! 

Anyhow, the issue of how the Krunner webshortcut plugin works has been completely modified for the upcoming KDE 4.6 release.  See the commit below:

http://websvn.kde.org/trunk/KDE/kdebase/workspace/plasma/generic/runners/webshortcuts/webshortcutrunner.cpp?r1=1171734&r2=1172660

Comment 4 Dawit Alemayehu 2010-11-28 05:45:50 UTC

Another reference http://reviewboard.kde.org/r/4040/