Bug 217159

Summary:	JJ: Enter key in playlist search does nothing
Product:	[Applications] amarok	Reporter:	Neil Skrypuch <kde>
Component:	Playlist	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	cycoone, nhn, teo
Priority:	NOR	Keywords:	junior-jobs
Version:	2.2.1
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	Patch which resets the search term when enter is pressed

Description Neil Skrypuch 2009-12-03 06:14:36 UTC

Version:           2.2.1 (using 4.3.3 (KDE 4.3.3), Gentoo)
Compiler:          gcc version 4.3.4 (Gentoo 4.3.4 p1.0, pie-10.1.5) 
OS:                Linux (x86_64) release 2.6.31-gentoo-r6

In 1.4, when you searched in the search bar, if you ended up with just a single track as the result of your search, you could hit enter and it would start playing that track and then clear your search. This was perfect. Now in 2.2.1 hitting enter in the search bar does nothing aside from removing focus from the search bar.

It would be really nice if enter in the search bar could work as it did in 1.4.

Comment 1 Stephen Baker 2010-01-09 01:54:46 UTC

In latest git this is mostly fixed, it just doesn't clear the search box.

Comment 2 Stephen Baker 2010-01-09 04:24:18 UTC

Created attachment 39707 [details]
Patch which resets the search term when enter is pressed

Applied against current head as of yesterday (0637b7d9c30d6725b0ec22a2bb07e530da035b1e)

Completes the behavior desired in this bug by clearing the search term.

Comment 3 Myriam Schweingruber 2010-01-09 09:08:13 UTC

Stephen, please make a merge request on http://gitorious.org/amarok so the developers can review the patch. Thank you.

Comment 4 Stephen Baker 2010-01-09 16:18:47 UTC

I can't get into Gitorious at the moment, as my account is stuck in limbo:

http://groups.google.ca/group/gitorious/browse_thread/thread/2e3c8caea471bc5b?hl=en

I'm fine if someone else wants to merge my patch while I get this straightened out.

Comment 5 Stephen Baker 2010-01-14 04:05:39 UTC

Disregard.  Gitorious is working for me now and I've requested the merge.

Comment 6 Nikolaj Hald Nielsen 2010-01-19 14:00:14 UTC

Merged.

It works well now when searching the playlist, but not when filtering (when "show only matches" is checked).

Comment 7 Stephen Baker 2010-01-21 04:51:43 UTC

I now have a merge request that fixes that case too; hopefully there's nothing else I missed.

Comment 8 Mark Kretschmann 2010-01-21 11:15:48 UTC

Thanks to Stephen for the new patch, I've just merged it into mainline. More testing welcome :)


commit 2886024e4592c47d3f1f67bdd56f9dce6318e60c
Author: Stephen Baker <cycoone@hotmail.com>
Date:   Wed Jan 20 22:41:10 2010 -0500

    Fix for "217159: Enter key in playlist does nothing" when show only matches is on

    Makes find select the first match even in filter mode.  This allows actions on the match like play to be performed just as they can on non-filtered mode.