Summary: | Crash after pressing Control-Z in Kolourpaint | ||
---|---|---|---|
Product: | [Applications] kolourpaint | Reporter: | Alec Moskvin <alecm> |
Component: | general | Assignee: | kolourpaint-support |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | antjbryant, christoph.dalski, crabemail, igor.poboiko, oleg.atamanenko+kde, seriousmailadress, swestrup |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Unlisted Binaries | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: |
New crash information added by DrKonqi
New crash information added by DrKonqi Patch to bug #211481 |
Description
Alec Moskvin
2009-10-22 22:42:29 UTC
Hello, I've just found a way to reproduce this crash for sure running : kolourpaint KDE 4.3.0 Linux (i686) release 2.6.27.30-170.2.82.fc10.i686 gcc 1) Open kolourpaint 2) Select an area and move it 3) Try to write text somewhere (only select a zone, do not type any character) 4) Then undo (while the square zone for typing characters is displayed) 5) Crash I can also reproduce this on KDE 4.4 RC2 (thanks psk!) Qt: 4.6.1 KDE Development Platform: 4.3.95 (KDE 4.3.95 (KDE 4.4 RC2)) KolourPaint: 4.3.95 (KDE 4.3.95 (KDE 4.4 RC2)) Created attachment 41436 [details] New crash information added by DrKonqi I was trying to add text to the screenshot (to report bug #229915) and suddenly kolourpaint crashed. Created attachment 42655 [details]
New crash information added by DrKonqi
I added some text to my picture, pressed 'Ctrl+Z' and kolourpaint crashed (segmentation fault)
Backtrace attached.
I can also confirm this bug with kde4.4 on archlinux. Just do the following steps: - open kolourpaint - write some text into a text field - press control+a - press control+z => Crash Created attachment 47979 [details] Patch to bug #211481 This patch fixes problem (tested with steps from comment #5 and comment #1). It also fixes some compilation errors when some DEBUG defines are set to 1. This bug happens every time when after pressing Ctrl+Z selection type changes (for example, from text selection to image selection - like in comment #1, or from image selection to text selection - like in comment #5) According to documentation (kpDocument::setSelection function), we mustn't call kpDocument::setSelection to set image selection when text selection is active and vice versa. If we must do it, we must push previous selection onto document (this is doing my patch) SVN commit 1137954 by cfeck: Fix "Undo" crash after changing selection mode Patch by Igor Poboiko, thanks! BUG: 211481 M +4 -0 commands/tools/selection/kpToolSelectionDestroyCommand.cpp M +3 -1 document/kpDocument_Selection.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1137954 SVN commit 1137955 by cfeck: Fix "Undo" crash after changing selection mode (backport r1137954) Patch by Igor Poboiko, thanks! CCBUG: 211481 FIXED-IN: 4.4.5 M +4 -0 commands/tools/selection/kpToolSelectionDestroyCommand.cpp M +3 -1 document/kpDocument_Selection.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1137955 *** Bug 157684 has been marked as a duplicate of this bug. *** *** Bug 254326 has been marked as a duplicate of this bug. *** *** Bug 236464 has been marked as a duplicate of this bug. *** |