Summary: | [Patch] Searching on Local Music, title:... does not work | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Roberto Bertolusso <rbertolusso> |
Component: | Collection Browser | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kfunk, maximilian.kossick, rbertolusso |
Priority: | NOR | ||
Version: | 2.2.0 | ||
Target Milestone: | 2.2.2 | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | Proposed patch to solve the bug |
Description
Roberto Bertolusso
2009-10-20 21:01:17 UTC
BTW, you don't have to subscribe to the bugs you report, since the reporter is subscribed by default. I think I have solved it. A whole section for dealing with title was missing from CollectionTreeItemModelBase.cpp. If the following chunk of code is inserted say at line 547 (from Amarok 2.2.0 source code), it fixes it. I really don't know how should I report it, so sorry if this is not the correct way *** Follows code to be added at line 547 **** else if ( lcField.compare( "title", Qt::CaseInsensitive ) == 0|| lcField.compare( i18n( "title" ), Qt::CaseInsensitive ) == 0 ) { if ( ( validFilters & QueryMaker::TitleFilter ) == 0 ) continue; ADD_OR_EXCLUDE_FILTER( Meta::valTitle, elem.text, false, false ); } *** Ends added code *** Maximilian, could you have a look at this, please? @RB: FYI, you should use `git diff` to get a patch out of your working tree. It's more readable. Even better: Make a "merge request" on Gitorious: http://gitorious.org/amarok/amarok/merge_requests/new Created attachment 37846 [details] Proposed patch to solve the bug This patch should address this issue. It is in response to comment #4, using 'git diff'. About comment #5 I have requested an account at gitorious, and waiting for the confirmation link Roberto, could you please send us a Merge Request on Gitorious instead? This makes it much easier for us to keep track of patches, and it allows you to refine the patch further if there are problems with it. Please see here: http://gitorious.org/amarok/amarok/merge_requests It is already there (ID #1920), with status "verifying" and waiting due to string freeze. Merged. Thanks Roberto. commit 026697891ec2d8a895c077d2c851d3d36619719b Merge: cec5ea8 6bd9594 Author: Mark Kretschmann <kretschmann@kde.org> Date: Thu Nov 12 07:09:32 2009 +0100 Merge commit 'refs/merge-requests/1920' of git://gitorious.org/amarok/amarok |