Summary: | [PATCH] Amarok 2.2.0 fails to import 1.4 Postgresql collection | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Ionut Ciocirlan <ionut.ciocirlan> |
Component: | general | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | amg1127, ruiz |
Priority: | NOR | ||
Version: | 2.2.0 | ||
Target Milestone: | --- | ||
Platform: | Debian testing | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | Patch made by me that fixes PostgreSQL database importing from Amarok 1.4 (i hope) |
Description
Ionut Ciocirlan
2009-10-02 06:04:02 UTC
QT 4.5 documentation says the constructor "QSqlQuery(const QString & query = QString(), QSqlDatabase db = QSqlDatabase() )" automatically calls exec() when it receives a non-empty string. http://qt.nokia.com/doc/4.5/qsqlquery.html#QSqlQuery-2 http://qt.gitorious.org/qt/qt/blobs/4.5/src/sql/kernel/qsqlquery.cpp#line282 My guess is: the line 140 of "src/databaseimporter/amarok14/FastForwardWorker.cpp" should not be there, because it tells the QSqlQuery object to execute a second (and not prepared yet) query. http://gitorious.org/amarok/amarok/blobs/master/src/databaseimporter/amarok14/FastForwardWorker.cpp#line140 ---- I'm now downloading Amarok 2.2 source code (Ubuntu 8.10 package). I will try to comment that line and see if that change makes importing from amarok 1.4 work again. @Anderson: That's great, a patch (or merge request) would be very welcome. Created attachment 37501 [details]
Patch made by me that fixes PostgreSQL database importing from Amarok 1.4 (i hope)
I hope the command line "$ diff -C 3 <original file> <modified file>" makes an useful patch... I used to apply patch from others, but this is my first patch ever... :-)
Thanks, I've committed your patch. Seb, do you think the patch is OK? commit f8d604e3c9111db376337fd0b20129162ed28f51 Author: Mark Kretschmann <kretschmann@kde.org> Date: Sun Oct 11 11:58:53 2009 +0200 Fix database import from Amarok 1.4 for Postgres. Patch by Anderson <amg1127@cefetrs.tche.br>. Please test :) @Seb: Do you think the patch is OK? BUG: 209175 |