Bug 194681

Summary: bashism in oppdater.sh script
Product: [Translations] i18n Reporter: Raphael Geissert <atomo64>
Component: nnAssignee: Gaute Hvoslef Kvalnes <gaute>
Status: RESOLVED FIXED    
Severity: normal CC: aacid, karl
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Debian testing   
OS: Unspecified   
Latest Commit: Version Fixed In:
Attachments: Fix bashisms

Description Raphael Geissert 2009-05-30 19:39:05 UTC 
Version:           4.2.2 (using KDE 4.2.2)
Installed from:    Debian testing/unstable Packages

While hunting down bashisms in Debian packages I found the following in the oppdater.sh script:

possible bashism in ./usr/share/locale/nn/LC_SCRIPTS/kdelibs4/oppdater.sh line 37 (echo -e):
echo -e '\n\n'
possible bashism in ./usr/share/locale/nn/LC_SCRIPTS/kdelibs4/oppdater.sh line 44 (should be 'b = a'):
if [ "$tooold" == 0 ]

Attachinig patch in a moment. The Debian maintainers have also suggested to stop including those scripts in the install target.
Comment 1 Raphael Geissert 2009-05-30 19:39:52 UTC 
Created attachment 34129 [details]
Fix bashisms
Comment 2 Albert Astals Cid 2009-08-05 23:06:13 UTC 
Karl can you have a look please?
Comment 3 Karl Ove Hufthammer 2009-08-26 19:45:25 UTC 
The script was not actually used by KDE; it was only an internal script for use by the translators. I’ve now removed it from SVN. Please close this bug as ‘fixed’ (I don’t have permission to do so).
Comment 4 Albert Astals Cid 2009-08-26 21:26:32 UTC 
Fixed, i've also given you some more karma.