Bug 192512

Summary: Regression in script argument order in script launcher
Product: [Applications] konversation Reporter: Eike Hein <hein>
Component: generalAssignee: Konversation Developers <konversation-devel>
Status: RESOLVED NOT A BUG    
Severity: normal    
Priority: NOR    
Version: Git   
Target Milestone: ---   
Platform: Unlisted Binaries   
OS: Linux   
Latest Commit: Version Fixed In:
Bug Depends on:    
Bug Blocks: 187307    

Description Eike Hein 2009-05-13 00:27:01 UTC
The signature for the D-Bus 'say' interface used by scripts is currently as follows:

method void org.kde.konversation.say(QString server, QString target, QString command)

However, the script launcher code currently passes the arguments in 'target connectionId' order when it runs a script. This is problematic:

- It would be more intuitive for script authors if the positions of the arguments handed to the script would correspond to the positions they need to be used in in the D-Bus call.

- It's a change from Konversation/KDE3, where the arguments passed to scripts were 'port connectionId target'. "Port" no longer being relevant to us with D-Bus, this leaves 'connectionId target', i.e. exactly the opposite of what the KDE 4 port does right now.

This should be changed before we make any public release of the KDE 4 port so we don't annoy script authors too much by changing it later. It also means we need to edit all the bundled scripts again.
Comment 1 Eike Hein 2009-05-14 00:15:16 UTC
Ok, this turned out to be bogus. There's no bug to see here, move along. *waves hands*