Bug 186159

Summary: regression gif animation is broken
Product: [Applications] konqueror Reporter: Eugene Shalygin <eugene.shalygin+bugzilla.kde>
Component: khtmlAssignee: Konqueror Developers <konq-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: realnc
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:

Description Eugene Shalygin 2009-03-04 22:47:06 UTC 
Version:            (using Devel)
Compiler:          gcc 4.3.3 
OS:                Linux
Installed from:    Compiled sources

KHTML does not render animated gif images. However, after any page or window redraw, animated image advance to the next frame.
Comment 1 Maksim Orlovich 2009-03-04 23:13:05 UTC 
Qt4.5, right?
Comment 2 Eugene Shalygin 2009-03-04 23:18:28 UTC 
(In reply to comment #1)
> Qt4.5, right?

Yes, from qt-copy. If it is a known problem maybe I can to something to help fix this?
Comment 3 Maksim Orlovich 2009-03-06 19:08:41 UTC 
*** Bug 186369 has been marked as a duplicate of this bug. ***
Comment 4 Nikos Chantziaras 2009-03-06 19:12:14 UTC 
Same here, and not only with Qt 4.5.0.  The bug was there with KDE 4.2.0 and 4.1.3 with Qt 4.4.2.
Comment 5 Maksim Orlovich 2009-03-06 19:20:44 UTC 
Uhm, I have exactly the same KDE running with Qt 4.5 and an older build of Qt4.4.x, and in one animated gifs work, and in another they don't. Perhaps the problem was triggered in a later Qt4.4.x version, but it's clear that a Qt change triggered it.
Comment 6 Maksim Orlovich 2009-03-24 21:04:15 UTC 
SVN commit 943998 by orlovich:

Give the proper dirty rectangle when switching frames in animated images.
The previous code mostly worked with Qt4.4 by some happy happenstance, but failed cleanly with Qt4.5 --- yey to that.

BUG:175858
BUG:186159


 M  +1 -1      animprovider.cpp  
 M  +6 -0      image.cpp  
 M  +5 -0      image.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=943998
Comment 7 Maksim Orlovich 2009-03-24 21:06:05 UTC 
SVN commit 943999 by orlovich:

Merged revision:r943998 | orlovich | 2009-03-24 16:04:11 -0400 (Tue, 24 Mar 2009) | 6 lines

Give the proper dirty rectangle when switching frames in animated images.
The previous code mostly worked with Qt4.4 by some happy happenstance, but failed cleanly with Qt4.5 --- yey to that.

BUG:175858
BUG:186159

 M  +1 -1      animprovider.cpp  
 M  +6 -0      image.cpp  
 M  +5 -0      image.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=943999
Comment 8 Nikos Chantziaras 2009-03-24 23:01:33 UTC 
This fixes it.  However, CPU load is too high :P  On the same page containing animated GIFs, Firefox needs 1% CPU, Konqueror 10%. That's exactly an order of magnitude :P