Bug 181765

Summary:	Dolphin doesn't display folder names with '&' right in tab bar
Product:	[Applications] dolphin	Reporter:	Lasse Liehu <lasse.liehu>
Component:	general	Assignee:	Peter Penz <peter.penz19>
Status:	RESOLVED FIXED
Severity:	normal	CC:	frank78ac
Priority:	NOR
Version:	16.12.2
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	Patch to fix it

Description Lasse Liehu 2009-01-24 15:41:13 UTC

Version:           1.1.80 (using 4.1.96 (KDE 4.1.96 (KDE 4.2 RC1)), Gentoo)
Compiler:          i686-pc-linux-gnu-gcc
OS:                Linux (i686) release 2.6.27-sabayon

Steps to reproduce:
1. open a new tab to make the tab bar visible
2. enter to a directory whose name contains '&', for example "Foo&Bar"
3. see how the name in the tab bar is "FooBar", with 'B' possibly underlined

Note: It's the same with "Foo & Bar". This doesn't occur only when a non-space character follows the '&'.

Comment 1 Frank Reininghaus 2009-01-26 22:21:26 UTC

Thanks for the bug report. I can confirm the issue in trunk rev. 917091. The problem is that QTabBar::setTabText() interprets the "&" in the directory name as an indicator for a keyboard shortcut. According to http://doc.trolltech.com/4.4/qtabwidget.html#setTabText , this can be avoided by passing "&&" instead of "&".

Comment 2 Frank Reininghaus 2009-01-26 22:21:59 UTC

Created attachment 30641 [details]
Patch to fix it

Comment 3 Peter Penz 2009-01-29 19:58:49 UTC

Thanks Frank for the patch, looks fine! I'll do a test and will commit the patch during the next week...

Comment 4 Peter Penz 2009-01-31 12:19:02 UTC

SVN commit 919023 by ppenz:

Backport of SVN commit 919021: Display correct folder names in tabs, if they contain a '&' character. Thanks to Frank Reininghaus for the patch!

CCBUG: 181765

 M  +4 -0      dolphinmainwindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=919023

Comment 5 Peter Penz 2009-01-31 12:19:03 UTC

SVN commit 919021 by ppenz:

Display correct folder names in tabs, if they contain a '&' character. Thanks to Frank Reininghaus for the patch!

BUG: 181765

 M  +4 -0      dolphinmainwindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=919021