Summary: | Can't create new photoset: Invalid primary photo id (n) [patch] | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | Will Stephenson <wstephenson> |
Component: | Plugin-WebService-Flickr | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | elmargol, jm, lure, p.edelman |
Priority: | NOR | ||
Version: | 5.6.0 | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 0.5.0 | |
Attachments: |
Delay photo set creation until first picture is uploaded
Updated patch against latest svn r978055 |
Description
Will Stephenson
2009-01-08 19:57:38 UTC
Do you use KDE3 or KDE4 version of kipi-plugins ? Gilles Caulier 0.2beta5 on KDE 4. Any bugreport from me on digikam refers to KDE 4. See also this thread: http://mail.kde.org/pipermail/digikam-users/2009-March/007229.html Created attachment 33708 [details] Delay photo set creation until first picture is uploaded Flickr doesn't know the concept of empty photosets, is expects that sets are created from an already present set of photos, one of which should be the main photo. I think the most sensible thing to do is to delay the actual creation of the photo set until the first photo for it is uploaded. The following patch implements this principle. After the photo set creation dialog is executed, a new FPhotoSet object is created with a temporary ID in the form of "UNIDENTIFIED_" followed by a unique number, instead of the Flickr ID. When the addToPhotoSet method encounters this, it invokes the createPhotoSet method. The resulting ID is consequently set in the FPhotoSet object and the relevant entry in the m_photoSetList. To facilitate this, I modified the FlickrTalker object so that it doesn’t store the ID of the selected photo (m_selectedPhotoSetId), but instead the complete FPhotoSet (m_selectedPhotoSet). This patch removes the 'primary photo id' option altogether from the photo set creation dialogue. I also removed the 'photoset name' option – as far as I can tell it isn't used for anything. This patch implies the patch in bug 192541. Pieter, Thanks you for your patch. it's very appreciate. Mathias, As you use and know Flickr Export plugin, can you take a look please ? Thanks in advance Gilles If someone has a binary of the plugin available somewhere with Pieter's patch, I'm willing to test it. Created attachment 34320 [details]
Updated patch against latest svn r978055
I tested Pieter's patch (refreshed version attached) against latest svn. The patch does work as intended. Creating a new set has a simplified dialog, only requiring the title and description. The set was created and the first uploaded photo was set as the primary photo. I was also able to upload photos directly to my photostream, without needing to add them to a set.
*** Bug 196179 has been marked as a duplicate of this bug. *** targeted to 0.5.0 release. SVN commit 991484 by nlecureuil: Fix creation of photoset ( Patch from Pieter Edelman and enhanced by James Vega ) BUG:180055 BUG:192541 CCMAIL:vega.james@gmail.com CCMAIL:p.edelman@gmx.net M +2 -1 NEWS M +8 -57 flickrexport/flickralbumdialog.ui M +50 -25 flickrexport/flickrtalker.cpp M +6 -1 flickrexport/flickrtalker.h M +73 -23 flickrexport/flickrwindow.cpp M +2 -1 flickrexport/flickrwindow.h WebSVN link: http://websvn.kde.org/?view=rev&revision=991484 |