Summary: | Akregator does not remember font size settings because there are two conflicting default values | ||
---|---|---|---|
Product: | [Applications] akregator | Reporter: | Frank Reininghaus <frank78ac> |
Component: | general | Assignee: | kdepim bugs <kdepim-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | frank78ac, osterfeld, rdieter |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Frank Reininghaus
2008-12-23 21:55:45 UTC
SVN commit 909069 by osterfeld: don't set default values for font sizes but rely on initFonts() find sensible defaults fixes the case if the user-defined font size equals the default size. BUG: 178605 _M . (directory) M +3 -7 akregator/src/akregator_part.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=909069 It seems that the bug is not fixed: I'm still unable to set the medium font size to 12 in trunk rev. 909208. It still gets reset to 10 if I close and reopen Akregator. I can't see how the patch could actually fix the issue: In the initialisation of the medium font size, if (konq.hasKey("MediumFontSize")) medfs = konq.readEntry("MediumFontSize", 0); was replaced by if (konq.hasKey("MediumFontSize")) medfs = konq.readEntry("MediumFontSize", 12); i.e., only the default to be used if no "MediumFontSize" key is found in the Konqueror settings was changed, but because that statement is only executed if konq.hasKey("MediumFontSize") is true, the change does not have any effect. SVN commit 911030 by osterfeld: backport: don't set default values for font sizes but rely on initFonts() find sensible defaults fixes the case if the user-defined font size equals the default size. CCBUG: 178605 M +0 -2 interfaces/akregator.kcfg M +3 -7 src/akregator_part.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=911030 Please retry now, I committed an additional change in 909639 (but put the wrong bug in CCBUG) Yes, 909639 fixes it. Thanks! Ok, fixed now. The original commit broke the font sizes though when starting akregator the first time. That's fixed now, too. |