Bug 177178

Summary:	Kwin KCM module creates invalid kwinrc file
Product:	[Plasma] kwin	Reporter:	Adam Pigg <adam>
Component:	general	Assignee:	KWin default assignee <kwin-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kde
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	My kwinrc on login kwinrc when apply the shadow effect from the general tab kwinrc when apply wobbly window on the advanced tab

Description Adam Pigg 2008-12-07 22:31:41 UTC

Version:           4.1.82 (using Devel)
OS:                Linux
Installed from:    Compiled sources

Between 4.8.81 and 4.1.82, something caused the kwinrc file to become corrupted when settings are applied in the kwin kcm module.

From the user perspective it appears that settings arnt being saved, for example, selecting the wobbly window plugin, clicking ok, then going back in shows the wobblywindow not selected.

Looking at kwinrc though, almost every setting is duplicated, and here you can see that wobbly window is both true and false.

Comment 1 Adam Pigg 2008-12-07 22:33:24 UTC

Created attachment 29128 [details]
My kwinrc on login

Comment 2 Adam Pigg 2008-12-07 22:34:04 UTC

Created attachment 29129 [details]
kwinrc when apply the shadow effect from the general tab

Comment 3 Adam Pigg 2008-12-07 22:34:49 UTC

Created attachment 29130 [details]
kwinrc when apply wobbly window on the advanced tab

This is where the duplicates are visible

Comment 4 lucas 2008-12-08 06:08:34 UTC

SVN commit 894182 by lmurray:

Reverted all code relating to automatic X crash detection with agreement
from David. Due to an elusive bug somewhere in kdelibs we have not been
able to find out how to fix the issues that some people were having.
There seems to be a race condition as I cannot reproduce at all, David
can reproduce sporadically and some reporters can always reproduce.

This commit attempts to also keep the code style changes that were made
at the same time as the original commit as well as some minor bug fixes
that were made between then and now. Hopefully I didn't miss anything.

We will be revisit this in KDE 4.3.

BUG: 177178

 M  +148 -241  kcmkwin/kwincompositing/main.cpp  
 M  +14 -19    kcmkwin/kwincompositing/main.h  
 M  +35 -72    options.cpp  
 M  +1 -7      options.h  
 M  +4 -1      org.kde.KWin.xml  
 M  +19 -4     workspace.cpp  
 M  +3 -2      workspace.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=894182