Bug 174650

Summary:	profile management: favourite icon abuse
Product:	[Applications] konsole	Reporter:	Maciej Pilichowski <bluedzins>
Component:	general	Assignee:	Konsole Developer <konsole-devel>
Status:	RESOLVED FIXED
Severity:	normal	CC:	robertknight, wrar
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Unspecified
Latest Commit:		Version Fixed In:

Description Maciej Pilichowski 2008-11-08 19:31:37 UTC

Version:            (using KDE 4.1.3)

profile management: favourite icon abuse

Please do not hijack icons -- favourite icon is for setting favourite items. However Konsole in PM uses this icon to turn on/off profile in the menu. For this is another icon, check mark, similar to
v
so please use it. All KDE apps should look and behave in consistent, uniform manner.

Comment 1 Robert Knight 2009-01-27 11:21:12 UTC

> favourite icon is for setting favourite items.

Yes, that's how I think of it as well.  It just happens that only 'favorite' items are shown in the menu.  Originally I was going to have another sub-menu 'More Profiles' or similar which listed the other profiles in the menu but I haven't implemented that yet.

Comment 2 Kurt Hindenburg 2009-02-03 06:45:50 UTC

SVN commit 920520 by hindenburg:

Use checkmark instead of favorite icon for turning on/off profiles in the menu.

BUG: 174650


 M  +2 -2      ManageProfilesDialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=920520

Comment 3 Kurt Hindenburg 2009-02-22 08:19:56 UTC

With kdelibs/base installed and running from Xfce, the checkmark doesn't appear.

I'm not sure if it because I'm not running KDE or just have libs/base installed.

Comment 4 Kurt Hindenburg 2009-02-23 03:16:14 UTC

SVN commit 930319 by hindenburg:

Change icon used to select profile to appear in menu.

CCBUG: 174650


 M  +2 -2      ManageProfilesDialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=930319