Summary: | kst miss last 2 indexes for dirfiles | ||
---|---|---|---|
Product: | [Applications] kst | Reporter: | karin dassas <karin.dassas> |
Component: | general | Assignee: | kst |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | arwalker, dvw, netterfield |
Priority: | NOR | ||
Version: | 1.x | ||
Target Milestone: | --- | ||
Platform: | Fedora RPMs | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
karin dassas
2008-11-06 11:06:01 UTC
This was a "feature" added in the days of the Ur-getdata to make streaming dirfiles work with kst. It currently lives in DirFileSource::update, where kst simply subtracts two from the number of frames that GetData reports. Ideally it should be removed. AFACT, kst should be able to work with a streamed dirfile (as long as appended to according to the Dirfile Standards) without it. However Barth have a better idea of how much (if any) breaking of streaming dirfiles would result by removing the magic minus two. This makes real time data over an nfs mounted drive more reliable. I agree that it may now be fine without it, as long as you mount with -o noac, but we would need to test that. Perhaps if we detect if we are streaming (nf == old_nf). If we are, subtract the 2, if not, read to the end. We really need to get the last 2 samples, as we've got sometimes some data with only one sample. We can't see the data at all with kst in that case. As the -2 seems at best to be a hack to work around a problem with streaming and is causing problems elsewhere I will remove it - unless there are any vocal complaints with good reasons not to do so. SVN commit 883489 by arwalker: BUG:174416 remove hard-coded magic number of -2 to make all data within a dirfile dataset available M +7 -4 dirfile.cpp M +3 -0 getdata.c WebSVN link: http://websvn.kde.org/?view=rev&revision=883489 |