Summary: | Changing "event source" in System Notifications causes "unsaved changes" | ||
---|---|---|---|
Product: | [Applications] systemsettings | Reporter: | Alan Jenkins <alan.christopher.jenkins> |
Component: | general | Assignee: | Unassigned bugs mailing-list <unassigned-bugs> |
Status: | RESOLVED WORKSFORME | ||
Severity: | normal | CC: | andresbajotierra |
Priority: | NOR | ||
Version: | 4.1 | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | Proposed fix |
Description
Alan Jenkins
2008-10-06 15:11:32 UTC
Created attachment 27741 [details]
Proposed fix
When "Event Source" is changed, the module saves the changes and emits changed(true), which means "I now have unsaved changes". What it should do is emit changed(false), which means "I have just saved all changes".
diff --git a/kcontrol/knotify/knotify.cpp b/kcontrol/knotify/knotify.cpp
index 1f6fa52..80fd62d 100644
--- a/kcontrol/knotify/knotify.cpp
+++ b/kcontrol/knotify/knotify.cpp
@@ -132,7 +132,7 @@ void KCMKNotify::slotAppActivated( int index )
text=m_appNames[index];
m_notifyWidget->save();
m_notifyWidget->setApplication( text );
- emit changed(true);
+ emit changed(false);
}
void KCMKNotify::slotPlayerSettings()
Hi. The code changed in KDE4.2 The "changed" signal isn't even emmited from KCMKNotify::slotAppActivated (confirmed here using :: kdebase svn rev. 902368) (I don't know if the patch was applied or another code refactor take care of the problem) |