Summary: | [OS X] Wikipedia applet does not open urls in default browser | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | illogic-al <illogical1> |
Component: | Context View | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | lfranchi, sven |
Priority: | NOR | Keywords: | needs_verification |
Version: | 2.0-SVN | ||
Target Milestone: | --- | ||
Platform: | Unlisted Binaries | ||
OS: | macOS | ||
Latest Commit: | Version Fixed In: |
Description
illogic-al
2008-10-01 23:39:45 UTC
I've looked up the actual code, here it comes: void WikipediaApplet::linkClicked( const QUrl &url ) { DEBUG_BLOCK debug() << "URL: " << url; KRun::runUrl( url, "text/html", 0 ); } Not sure if this is the recommended way to open HTML pages externally. SVN commit 878985 by markey: Use the Right Way (TM) to open web pages in external browser. BUG: 171995 M +3 -2 WikipediaApplet.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=878985 Definitely not fixed. Regression perhaps? *** Bug 175806 has been marked as a duplicate of this bug. *** Yeah, we did indeed change the code back to use Amarok::invokeBrowser(). Too bad that this doesn't work on OSX.. Might need an #ifdef for now. Discovered this thread on kde-core-devel discussing the problem: http://lists.kde.org/?t=122710352700002&r=1&w=2 I changed a lot in that area recently, so this might work now? Please check. indeed it does work now. thanks sven! |