Bug 168345

Summary:	JJ:startkde can't cope with KSplashX theme names containing spaces
Product:	[Plasma] ksplash	Reporter:	Eike Hein <hein>
Component:	general	Assignee:	Lubos Lunak <l.lunak>
Status:	RESOLVED FIXED
Severity:	normal	CC:	finex, l.lunak
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	diff for KDE/kdebase/workspace/startkde.cmake

Description Eike Hein 2008-08-04 16:43:29 UTC

Version:            (using KDE 4.1.0)
Installed from:    Gentoo Packages
Compiler:          gcc 4.3.1 
OS:                Linux

The startkde script doesn't quote the theme name argument given to the ksplashx executable, which makes it fail on themes that have spaces in their (folder) name. The KCM in System Settings does it correctly for the "Test Theme" theme preview action, however, which makes it inconsistent on top.

Comment 1 Olli Salonen 2009-01-08 12:09:01 UTC

Created attachment 30025 [details]
diff for KDE/kdebase/workspace/startkde.cmake

This is my first attempt at a KDE patch, so comments about etiquette are welcome.

The attached patch.diff is for trunk/KDE/kdebase/workspace/startkde.cmake (rev. 907017).
It adds double-quotes around the theme name in the startkde script for both ksplashx and ksplashsimple commands. It fixes the bug for me.

Comment 2 Tommi Tervo 2009-01-09 11:00:41 UTC

Patch committed to trunk and 4.2 branch, thanks Olli.